Drop using namespace in .h files

Summary:
using namespace in header file is a bad practice due to many reasons as well as discouraged by -Wheader-hygiene compiler flag which is default for many apps
https://stackoverflow.com/questions/5849457/using-namespace-in-c-headers
https://stackoverflow.com/questions/223021/whats-the-scope-of-the-using-declaration-in-c

Changelog:
[Internal] Drop `using namespace` in .h files.

Reviewed By: christophpurrer

Differential Revision: D40628064

fbshipit-source-id: 8a032f3ab0321a531e26bd88656ad9a65b6d5154

Author: p-sun

Libraries/Blob/RCTBlobCollector.h

@@ -7,8 +7,6 @@
 
 #import <jsi/jsi.h>
 
-using namespace facebook;
-
 @class RCTBlobManager;
 
 namespace facebook {

React/Fabric/Mounting/RCTComponentViewFactory.mm

@@ -39,6 +39,7 @@
 
 #import <objc/runtime.h>
 
+using namespace facebook;
 using namespace facebook::react;
 
 // Allow JS runtime to register native components as needed. For static view configs.

ReactCommon/react/renderer/core/tests/TestComponent.h

@@ -18,13 +18,13 @@
 #include <react/renderer/core/RawProps.h>
 #include <react/renderer/core/ShadowNode.h>
 
-using namespace facebook::react;
-
 /**
  * This defines a set of TestComponent classes: Props, ShadowNode,
  * ComponentDescriptor. To be used for testing purpose.
  */
 
+namespace facebook::react {
+
 class TestState {
  public:
   int number;
@@ -75,3 +75,5 @@ class TestComponentDescriptor
  public:
   using ConcreteComponentDescriptor::ConcreteComponentDescriptor;
 };
+
+} // namespace facebook::react

ReactCommon/react/renderer/imagemanager/platform/ios/RCTImagePrimitivesConversions.h

@@ -10,43 +10,41 @@
 #import <React/RCTImageLoader.h>
 #import <react/renderer/imagemanager/primitives.h>
 
-using namespace facebook::react;
-
-inline static UIViewContentMode RCTContentModeFromImageResizeMode(ImageResizeMode imageResizeMode)
+inline static UIViewContentMode RCTContentModeFromImageResizeMode(facebook::react::ImageResizeMode imageResizeMode)
 {
   switch (imageResizeMode) {
-    case ImageResizeMode::Cover:
+    case facebook::react::ImageResizeMode::Cover:
       return UIViewContentModeScaleAspectFill;
-    case ImageResizeMode::Contain:
+    case facebook::react::ImageResizeMode::Contain:
       return UIViewContentModeScaleAspectFit;
-    case ImageResizeMode::Stretch:
+    case facebook::react::ImageResizeMode::Stretch:
       return UIViewContentModeScaleToFill;
-    case ImageResizeMode::Center:
+    case facebook::react::ImageResizeMode::Center:
       return UIViewContentModeCenter;
-    case ImageResizeMode::Repeat:
+    case facebook::react::ImageResizeMode::Repeat:
       // Repeat resize mode is handled by the UIImage. Use scale to fill
       // so the repeated image fills the UIImageView.
       return UIViewContentModeScaleToFill;
   }
 }
 
-inline std::string toString(const ImageResizeMode &value)
+inline std::string toString(const facebook::react::ImageResizeMode &value)
 {
   switch (value) {
-    case ImageResizeMode::Cover:
+    case facebook::react::ImageResizeMode::Cover:
       return "cover";
-    case ImageResizeMode::Contain:
+    case facebook::react::ImageResizeMode::Contain:
       return "contain";
-    case ImageResizeMode::Stretch:
+    case facebook::react::ImageResizeMode::Stretch:
       return "stretch";
-    case ImageResizeMode::Center:
+    case facebook::react::ImageResizeMode::Center:
       return "center";
-    case ImageResizeMode::Repeat:
+    case facebook::react::ImageResizeMode::Repeat:
       return "repeat";
   }
 }
 
-inline static NSURL *NSURLFromImageSource(const ImageSource &imageSource)
+inline static NSURL *NSURLFromImageSource(const facebook::react::ImageSource &imageSource)
 {
   // `NSURL` has a history of crashing with bad input, so let's be safe.
   @try {
@@ -92,7 +90,7 @@ inline static NSURL *NSURLFromImageSource(const ImageSource &imageSource)
   }
 }
 
-inline static NSURLRequest *NSURLRequestFromImageSource(const ImageSource &imageSource)
+inline static NSURLRequest *NSURLRequestFromImageSource(const facebook::react::ImageSource &imageSource)
 {
   NSURL *url = NSURLFromImageSource(imageSource);
 

ReactCommon/react/renderer/textlayoutmanager/platform/ios/RCTTextPrimitivesConversions.h

@@ -10,50 +10,50 @@
 #include <react/renderer/textlayoutmanager/RCTFontProperties.h>
 #include <react/renderer/textlayoutmanager/RCTFontUtils.h>
 
-using namespace facebook::react;
-
-inline static NSTextAlignment RCTNSTextAlignmentFromTextAlignment(TextAlignment textAlignment)
+inline static NSTextAlignment RCTNSTextAlignmentFromTextAlignment(facebook::react::TextAlignment textAlignment)
 {
   switch (textAlignment) {
-    case TextAlignment::Natural:
+    case facebook::react::TextAlignment::Natural:
       return NSTextAlignmentNatural;
-    case TextAlignment::Left:
+    case facebook::react::TextAlignment::Left:
       return NSTextAlignmentLeft;
-    case TextAlignment::Right:
+    case facebook::react::TextAlignment::Right:
       return NSTextAlignmentRight;
-    case TextAlignment::Center:
+    case facebook::react::TextAlignment::Center:
       return NSTextAlignmentCenter;
-    case TextAlignment::Justified:
+    case facebook::react::TextAlignment::Justified:
       return NSTextAlignmentJustified;
   }
 }
 
-inline static NSWritingDirection RCTNSWritingDirectionFromWritingDirection(WritingDirection writingDirection)
+inline static NSWritingDirection RCTNSWritingDirectionFromWritingDirection(
+    facebook::react::WritingDirection writingDirection)
 {
   switch (writingDirection) {
-    case WritingDirection::Natural:
+    case facebook::react::WritingDirection::Natural:
       return NSWritingDirectionNatural;
-    case WritingDirection::LeftToRight:
+    case facebook::react::WritingDirection::LeftToRight:
       return NSWritingDirectionLeftToRight;
-    case WritingDirection::RightToLeft:
+    case facebook::react::WritingDirection::RightToLeft:
       return NSWritingDirectionRightToLeft;
   }
 }
 
-inline static NSLineBreakStrategy RCTNSLineBreakStrategyFromLineBreakStrategy(LineBreakStrategy lineBreakStrategy)
+inline static NSLineBreakStrategy RCTNSLineBreakStrategyFromLineBreakStrategy(
+    facebook::react::LineBreakStrategy lineBreakStrategy)
 {
   switch (lineBreakStrategy) {
-    case LineBreakStrategy::None:
+    case facebook::react::LineBreakStrategy::None:
       return NSLineBreakStrategyNone;
-    case LineBreakStrategy::PushOut:
+    case facebook::react::LineBreakStrategy::PushOut:
       return NSLineBreakStrategyPushOut;
-    case LineBreakStrategy::HangulWordPriority:
+    case facebook::react::LineBreakStrategy::HangulWordPriority:
       if (@available(iOS 14.0, *)) {
         return NSLineBreakStrategyHangulWordPriority;
       } else {
         return NSLineBreakStrategyNone;
       }
-    case LineBreakStrategy::Standard:
+    case facebook::react::LineBreakStrategy::Standard:
       if (@available(iOS 14.0, *)) {
         return NSLineBreakStrategyStandard;
       } else {
@@ -62,38 +62,39 @@ inline static NSLineBreakStrategy RCTNSLineBreakStrategyFromLineBreakStrategy(Li
   }
 }
 
-inline static RCTFontStyle RCTFontStyleFromFontStyle(FontStyle fontStyle)
+inline static RCTFontStyle RCTFontStyleFromFontStyle(facebook::react::FontStyle fontStyle)
 {
   switch (fontStyle) {
-    case FontStyle::Normal:
+    case facebook::react::FontStyle::Normal:
       return RCTFontStyleNormal;
-    case FontStyle::Italic:
+    case facebook::react::FontStyle::Italic:
       return RCTFontStyleItalic;
-    case FontStyle::Oblique:
+    case facebook::react::FontStyle::Oblique:
       return RCTFontStyleOblique;
   }
 }
 
-inline static RCTFontVariant RCTFontVariantFromFontVariant(FontVariant fontVariant)
+inline static RCTFontVariant RCTFontVariantFromFontVariant(facebook::react::FontVariant fontVariant)
 {
   return (RCTFontVariant)fontVariant;
 }
 
-inline static NSUnderlineStyle RCTNSUnderlineStyleFromTextDecorationStyle(TextDecorationStyle textDecorationStyle)
+inline static NSUnderlineStyle RCTNSUnderlineStyleFromTextDecorationStyle(
+    facebook::react::TextDecorationStyle textDecorationStyle)
 {
   switch (textDecorationStyle) {
-    case TextDecorationStyle::Solid:
+    case facebook::react::TextDecorationStyle::Solid:
       return NSUnderlineStyleSingle;
-    case TextDecorationStyle::Double:
+    case facebook::react::TextDecorationStyle::Double:
       return NSUnderlineStyleDouble;
-    case TextDecorationStyle::Dashed:
+    case facebook::react::TextDecorationStyle::Dashed:
       return NSUnderlinePatternDash | NSUnderlineStyleSingle;
-    case TextDecorationStyle::Dotted:
+    case facebook::react::TextDecorationStyle::Dotted:
       return NSUnderlinePatternDot | NSUnderlineStyleSingle;
   }
 }
 
-inline static UIColor *RCTUIColorFromSharedColor(const SharedColor &sharedColor)
+inline static UIColor *RCTUIColorFromSharedColor(const facebook::react::SharedColor &sharedColor)
 {
   if (!sharedColor) {
     return nil;