standardize error messages thrown from inspector proxy when connection is closed to debugger (facebook#51227)

Summary:
Pull Request resolved: facebook#51227

Standardize error messages thrown from inspector proxy when connection is closed to debugger and link to where they are used in `react-native-devtools-frontend`

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D74484316

fbshipit-source-id: 7885bc5ea41397539814f97d764c9a376ef50eaa

Author: vzaidman

packages/dev-middleware/src/inspector-proxy/Device.js

@@ -44,10 +44,10 @@ const WS_CLOSURE_CODE = {
 };
 
 export const WS_CLOSE_REASON = {
-  PAGE_NOT_FOUND: 'Debugger Page Not Found',
-  DEVICE_DISCONNECTED: 'Corresponding Device Disconnected',
-  RECREATING_DEVICE: 'Recreating Device Connection',
-  RECREATING_DEBUGGER: 'Recreating Debugger Connection',
+  PAGE_NOT_FOUND: '[PAGE_NOT_FOUND] Debugger Page Not Found',
+  CONNECTION_LOST: '[CONNECTION_LOST] Connection lost to corresponding device',
+  RECREATING_DEVICE: '[RECREATING_DEVICE] Recreating Device Connection',
+  RECREATING_DEBUGGER: '[RECREATING_DEBUGGER] Recreating Debugger Connection',
 };
 
 // Prefix for script URLs that are alphanumeric IDs. See comment in #processMessageFromDeviceLegacy method for
@@ -219,7 +219,7 @@ export default class Device {
         // Device disconnected - close debugger connection.
         this.#terminateDebuggerConnection(
           WS_CLOSURE_CODE.NORMAL,
-          WS_CLOSE_REASON.DEVICE_DISCONNECTED,
+          WS_CLOSE_REASON.CONNECTION_LOST,
         );
         clearInterval(this.#pagesPollingIntervalId);
       }

packages/dev-middleware/src/inspector-proxy/InspectorProxy.js

@@ -47,6 +47,15 @@ const MIN_EVENT_LOOP_DELAY_PERCENT_TO_REPORT = 20;
 
 const INTERNAL_ERROR_CODE = 1011;
 
+// should be aligned with
+// https://github.com/facebook/react-native-devtools-frontend/blob/fa273092fbc8edc94d4a0a3621735f4677a99ba8/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts#L50
+const INTERNAL_ERROR_MESSAGES = {
+  UREGISTERED_DEVICE:
+    '[UREGISTERED_DEVICE] Debugger connection attempted for a device that was not registered',
+  INCORRECT_URL:
+    '[INCORRECT_URL] Incorrect URL - device and page IDs must be provided',
+};
+
 export type GetPageDescriptionsConfig = {
   requestorRelativeBaseUrl: URL,
   logNoPagesForConnectedDevice?: boolean,
@@ -507,13 +516,11 @@ export default class InspectorProxy implements InspectorProxyQueries {
 
       try {
         if (deviceId == null || pageId == null) {
-          throw new Error('Incorrect URL - must provide device and page IDs');
+          throw new Error(INTERNAL_ERROR_MESSAGES.INCORRECT_URL);
         }
 
         if (device == null) {
-          throw new Error(
-            'Debugger connection attempted for a non registered device',
-          );
+          throw new Error(INTERNAL_ERROR_MESSAGES.UREGISTERED_DEVICE);
         }
 
         this.#logger?.info(