Skip to content

Commit ad43dec

Browse files
hramosfacebook-github-bot
authored andcommitted
Remove unused saveFilesToRestore function
Summary: The method that would restore these files was removed in facebook#34846. The action performed by `saveFilesToRestore` is no longer necessary (thanks kelset for pointing this out). Changelog: [internal] Reviewed By: cortinico Differential Revision: D41003911 fbshipit-source-id: bbc057ac450e7f134c4664173291ca56c18f1b17
1 parent 7211366 commit ad43dec

File tree

2 files changed

+0
-25
lines changed

2 files changed

+0
-25
lines changed

scripts/publish-npm.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ const {
4141
const {
4242
generateAndroidArtifacts,
4343
publishAndroidArtifactsToMaven,
44-
saveFilesToRestore,
4544
} = require('./release-utils');
4645
const fs = require('fs');
4746
const os = require('os');
@@ -74,8 +73,6 @@ if (!argv.help) {
7473
echo(`The temp publishing folder is ${tmpPublishingFolder}`);
7574
}
7675

77-
saveFilesToRestore(tmpPublishingFolder);
78-
7976
// 34c034298dc9cad5a4553964a5a324450fda0385
8077
const currentCommit = getCurrentCommit();
8178
const shortCommit = currentCommit.slice(0, 9);

scripts/release-utils.js

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -10,29 +10,8 @@
1010
'use strict';
1111

1212
const {exec, echo, exit, test, env, pushd, popd} = require('shelljs');
13-
const {saveFiles} = require('./scm-utils');
1413
const {createHermesPrebuiltArtifactsTarball} = require('./hermes/hermes-utils');
1514

16-
// TODO: we should probably remove this because of this? https://github.com/facebook/react-native/pull/34846
17-
function saveFilesToRestore(tmpPublishingFolder) {
18-
const filesToSaveAndRestore = [
19-
'template/Gemfile',
20-
'template/_ruby-version',
21-
'template/package.json',
22-
'.ruby-version',
23-
'Gemfile.lock',
24-
'Gemfile',
25-
'package.json',
26-
'ReactAndroid/gradle.properties',
27-
'Libraries/Core/ReactNativeVersion.js',
28-
'React/Base/RCTVersion.m',
29-
'ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java',
30-
'ReactCommon/cxxreact/ReactNativeVersion.h',
31-
];
32-
33-
saveFiles(filesToSaveAndRestore, tmpPublishingFolder);
34-
}
35-
3615
function generateAndroidArtifacts(releaseVersion, tmpPublishingFolder) {
3716
// -------- Generating Android Artifacts
3817
echo('Generating Android artifacts inside /tmp/maven-local');
@@ -136,5 +115,4 @@ module.exports = {
136115
generateAndroidArtifacts,
137116
generateiOSArtifacts,
138117
publishAndroidArtifactsToMaven,
139-
saveFilesToRestore,
140118
};

0 commit comments

Comments
 (0)