Skip to content

Commit ce0dabd

Browse files
rshestfacebook-github-bot
authored andcommitted
Extract ImageSize type from NativeImageLoader interface (re-submit) (facebook#41577)
Summary: Pull Request resolved: facebook#41577 # Changelog: [Internal]- The change is equivalent in terms of API, however this makes it work nicer with C++ codegen and easier to use with a pure C++ implementation of the native module. Reviewed By: GijsWeterings Differential Revision: D51493466 fbshipit-source-id: bf9105670ae56a191ab2e6c8cfb794c2fecd4809
1 parent 33a44e6 commit ce0dabd

File tree

1 file changed

+8
-15
lines changed

1 file changed

+8
-15
lines changed

packages/react-native/Libraries/Image/NativeImageLoaderAndroid.js

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,24 +12,17 @@ import type {TurboModule} from '../TurboModule/RCTExport';
1212

1313
import * as TurboModuleRegistry from '../TurboModule/TurboModuleRegistry';
1414

15+
export type ImageSize = {
16+
width: number,
17+
height: number,
18+
...
19+
};
20+
1521
export interface Spec extends TurboModule {
1622
+abortRequest: (requestId: number) => void;
1723
+getConstants: () => {||};
18-
+getSize: (uri: string) => Promise<
19-
$ReadOnly<{
20-
width: number,
21-
height: number,
22-
...
23-
}>,
24-
>;
25-
+getSizeWithHeaders: (
26-
uri: string,
27-
headers: Object,
28-
) => Promise<{
29-
width: number,
30-
height: number,
31-
...
32-
}>;
24+
+getSize: (uri: string) => Promise<ImageSize>;
25+
+getSizeWithHeaders: (uri: string, headers: Object) => Promise<ImageSize>;
3326
+prefetchImage: (uri: string, requestId: number) => Promise<boolean>;
3427
+queryCache: (uris: Array<string>) => Promise<Object>;
3528
}

0 commit comments

Comments
 (0)