Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java (facebook#50059)

GijsWeterings · facebook-github-bot · commit e9af9a1793da · 2025-03-18T06:08:17.000-07:00
Summary: Pull Request resolved: facebook#50059 Note this diff is only adding FIXMEs that will be removed in the next diff. This diff exists to make the next diff easily reviewable Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D71126395 fbshipit-source-id: fb42b12dae542bde6e0e9e58baeaab054ed8c49e
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java
@@ -208,6 +208,7 @@ protected Void doInBackground(Void... params) {
 
         mInspectorPackagerConnection =
             new CxxInspectorPackagerConnection(
+                // NULLSAFE_FIXME[Parameter Not Nullable]
                 getInspectorDeviceUrl(), metadata.get("deviceName"), mPackageName);
         mInspectorPackagerConnection.connect();
         return null;
@@ -457,6 +458,7 @@ public String getSourceUrl(String mainModuleName) {
       }
 
       try (Sink output = Okio.sink(outputFile)) {
+        // NULLSAFE_FIXME[Nullable Dereference]
         Okio.buffer(response.body().source()).readAll(output);
       }
 

Original file line number	Diff line number	Diff line change
`@@ -208,6 +208,7 @@ protected Void doInBackground(Void... params) {`
`208`	`208`
`209`	`209`	`mInspectorPackagerConnection =`
`210`	`210`	`new CxxInspectorPackagerConnection(`
	`211`	`+ // NULLSAFE_FIXME[Parameter Not Nullable]`
`211`	`212`	`getInspectorDeviceUrl(), metadata.get("deviceName"), mPackageName);`
`212`	`213`	`mInspectorPackagerConnection.connect();`
`213`	`214`	`return null;`
`@@ -457,6 +458,7 @@ public String getSourceUrl(String mainModuleName) {`
`457`	`458`	`}`
`458`	`459`
`459`	`460`	`try (Sink output = Okio.sink(outputFile)) {`
	`461`	`+ // NULLSAFE_FIXME[Nullable Dereference]`
`460`	`462`	`Okio.buffer(response.body().source()).readAll(output);`
`461`	`463`	`}`
`462`	`464`