chore: Unify codegen Flow and TS default case from translateTypeAnnotation (facebook#35086)

Summary:
This PR unifies the Flow and TS `default:` case from codegen `translateTypeAnnotation` function into a single function
called `translateDefault` inside `parser-commons.js` as requested on facebook#34872.

## Changelog

[Internal] [Changed] - Unify codegen Flow and TS default case from translateTypeAnnotation

Pull Request resolved: facebook#35086

Test Plan:
Run `yarn jest react-native-codegen` and ensure CI is green

![image](https://user-images.githubusercontent.com/11707729/197931439-a0f0f7cd-eee7-4908-a7f1-856b40954178.png)

Reviewed By: cortinico

Differential Revision: D40801612

Pulled By: cipolleschi

fbshipit-source-id: 612768d6fabe091ac428e7d8416c6da059fe1332

Author: gabrieldonadel

packages/react-native-codegen/src/parsers/flow/components/schema.js

@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @format
- * @flow strict-local
+ * @flow strict
  */
 
 'use strict';

packages/react-native-codegen/src/parsers/flow/modules/index.js

@@ -39,6 +39,7 @@ const {
   assertGenericTypeAnnotationHasExactlyOneTypeParameter,
   emitMixedTypeAnnotation,
   emitUnionTypeAnnotation,
+  translateDefault,
 } = require('../../parsers-commons');
 const {
   emitBoolean,
@@ -59,9 +60,7 @@ const {
 const {
   UnnamedFunctionParamParserError,
   UnsupportedArrayElementTypeAnnotationParserError,
-  UnsupportedGenericParserError,
   UnsupportedTypeAnnotationParserError,
-  UnsupportedEnumDeclarationParserError,
   UnsupportedObjectPropertyTypeAnnotationParserError,
   IncorrectModuleRegistryCallArgumentTypeParserError,
 } = require('../../errors.js');
@@ -250,34 +249,11 @@ function translateTypeAnnotation(
           return emitObject(nullable);
         }
         default: {
-          const maybeEumDeclaration = types[typeAnnotation.id.name];
-          if (
-            maybeEumDeclaration &&
-            maybeEumDeclaration.type === 'EnumDeclaration'
-          ) {
-            const memberType = maybeEumDeclaration.body.type
-              .replace('EnumNumberBody', 'NumberTypeAnnotation')
-              .replace('EnumStringBody', 'StringTypeAnnotation');
-            if (
-              memberType === 'NumberTypeAnnotation' ||
-              memberType === 'StringTypeAnnotation'
-            ) {
-              return wrapNullable(nullable, {
-                type: 'EnumDeclaration',
-                memberType: memberType,
-              });
-            } else {
-              throw new UnsupportedEnumDeclarationParserError(
-                hasteModuleName,
-                typeAnnotation,
-                memberType,
-                language,
-              );
-            }
-          }
-          throw new UnsupportedGenericParserError(
+          return translateDefault(
             hasteModuleName,
             typeAnnotation,
+            types,
+            nullable,
             parser,
           );
         }

packages/react-native-codegen/src/parsers/flow/parser.js

@@ -10,9 +10,24 @@
 
 'use strict';
 
+import type {ParserType} from '../errors';
 import type {Parser} from '../parser';
 
 class FlowParser implements Parser {
+  getMaybeEnumMemberType(maybeEnumDeclaration: $FlowFixMe): string {
+    return maybeEnumDeclaration.body.type
+      .replace('EnumNumberBody', 'NumberTypeAnnotation')
+      .replace('EnumStringBody', 'StringTypeAnnotation');
+  }
+
+  isEnumDeclaration(maybeEnumDeclaration: $FlowFixMe): boolean {
+    return maybeEnumDeclaration.type === 'EnumDeclaration';
+  }
+
+  language(): ParserType {
+    return 'Flow';
+  }
+
   nameForGenericTypeAnnotation(typeAnnotation: $FlowFixMe): string {
     return typeAnnotation.id.name;
   }

packages/react-native-codegen/src/parsers/parser.js

@@ -10,11 +10,29 @@
 
 'use strict';
 
+import type {ParserType} from './errors';
+
 /**
  * This is the main interface for Parsers of various languages.
  * It exposes all the methods that contain language-specific logic.
  */
 export interface Parser {
+  /**
+   * Given a type declaration, it possibly returns the name of the Enum type.
+   * @parameter maybeEnumDeclaration: an object possibly containing an Enum declaration.
+   * @returns: the name of the Enum type.
+   */
+  getMaybeEnumMemberType(maybeEnumDeclaration: $FlowFixMe): string;
+  /**
+   * Given a type declaration, it returns a boolean specifying if is an Enum declaration.
+   * @parameter maybeEnumDeclaration: an object possibly containing an Enum declaration.
+   * @returns: a boolean specifying if is an Enum declaration.
+   */
+  isEnumDeclaration(maybeEnumDeclaration: $FlowFixMe): boolean;
+  /**
+   * @returns: the Parser language.
+   */
+  language(): ParserType;
   /**
    * Given a type annotation for a generic type, it returns the type name.
    * @parameter typeAnnotation: the annotation for a type in the AST.

packages/react-native-codegen/src/parsers/parsers-commons.js

@@ -28,6 +28,13 @@ const {
   UnsupportedObjectPropertyTypeAnnotationParserError,
 } = require('./errors');
 const invariant = require('invariant');
+import type {TypeDeclarationMap} from './utils';
+const {
+  UnsupportedEnumDeclarationParserError,
+  UnsupportedGenericParserError,
+} = require('./errors');
+import type {Parser} from './parser';
+import type {NativeModuleEnumDeclaration} from '../CodegenSchema';
 
 function wrapModuleSchema(
   nativeModuleSchema: NativeModuleSchema,
@@ -157,6 +164,44 @@ function emitUnionTypeAnnotation(
   });
 }
 
+function translateDefault(
+  hasteModuleName: string,
+  typeAnnotation: $FlowFixMe,
+  types: TypeDeclarationMap,
+  nullable: boolean,
+  parser: Parser,
+): Nullable<NativeModuleEnumDeclaration> {
+  const maybeEnumDeclaration =
+    types[parser.nameForGenericTypeAnnotation(typeAnnotation)];
+
+  if (maybeEnumDeclaration && parser.isEnumDeclaration(maybeEnumDeclaration)) {
+    const memberType = parser.getMaybeEnumMemberType(maybeEnumDeclaration);
+
+    if (
+      memberType === 'NumberTypeAnnotation' ||
+      memberType === 'StringTypeAnnotation'
+    ) {
+      return wrapNullable(nullable, {
+        type: 'EnumDeclaration',
+        memberType: memberType,
+      });
+    } else {
+      throw new UnsupportedEnumDeclarationParserError(
+        hasteModuleName,
+        typeAnnotation,
+        memberType,
+        parser.language(),
+      );
+    }
+  }
+
+  throw new UnsupportedGenericParserError(
+    hasteModuleName,
+    typeAnnotation,
+    parser,
+  );
+}
+
 function getKeyName(
   propertyOrIndex: $FlowFixMe,
   hasteModuleName: string,
@@ -190,4 +235,5 @@ module.exports = {
   emitMixedTypeAnnotation,
   emitUnionTypeAnnotation,
   getKeyName,
+  translateDefault,
 };

packages/react-native-codegen/src/parsers/typescript/components/schema.js

@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @format
- * @flow strict-local
+ * @flow strict
  */
 
 'use strict';

packages/react-native-codegen/src/parsers/typescript/modules/index.js

@@ -42,6 +42,7 @@ const {
   assertGenericTypeAnnotationHasExactlyOneTypeParameter,
   emitMixedTypeAnnotation,
   emitUnionTypeAnnotation,
+  translateDefault,
 } = require('../../parsers-commons');
 const {
   emitBoolean,
@@ -63,7 +64,6 @@ const {
   UnsupportedArrayElementTypeAnnotationParserError,
   UnsupportedGenericParserError,
   UnsupportedTypeAnnotationParserError,
-  UnsupportedEnumDeclarationParserError,
   UnsupportedObjectPropertyTypeAnnotationParserError,
   IncorrectModuleRegistryCallArgumentTypeParserError,
 } = require('../../errors.js');
@@ -264,36 +264,11 @@ function translateTypeAnnotation(
           return emitObject(nullable);
         }
         default: {
-          const maybeEumDeclaration = types[typeAnnotation.typeName.name];
-          if (
-            maybeEumDeclaration &&
-            maybeEumDeclaration.type === 'TSEnumDeclaration'
-          ) {
-            const memberType = maybeEumDeclaration.members[0].initializer
-              ? maybeEumDeclaration.members[0].initializer.type
-                  .replace('NumericLiteral', 'NumberTypeAnnotation')
-                  .replace('StringLiteral', 'StringTypeAnnotation')
-              : 'StringTypeAnnotation';
-            if (
-              memberType === 'NumberTypeAnnotation' ||
-              memberType === 'StringTypeAnnotation'
-            ) {
-              return wrapNullable(nullable, {
-                type: 'EnumDeclaration',
-                memberType: memberType,
-              });
-            } else {
-              throw new UnsupportedEnumDeclarationParserError(
-                hasteModuleName,
-                typeAnnotation,
-                memberType,
-                language,
-              );
-            }
-          }
-          throw new UnsupportedGenericParserError(
+          return translateDefault(
             hasteModuleName,
             typeAnnotation,
+            types,
+            nullable,
             parser,
           );
         }

packages/react-native-codegen/src/parsers/typescript/parser.js

@@ -10,9 +10,28 @@
 
 'use strict';
 
+import type {ParserType} from '../errors';
 import type {Parser} from '../parser';
 
 class TypeScriptParser implements Parser {
+  getMaybeEnumMemberType(maybeEnumDeclaration: $FlowFixMe): string {
+    if (maybeEnumDeclaration.members[0].initializer) {
+      return maybeEnumDeclaration.members[0].initializer.type
+        .replace('NumericLiteral', 'NumberTypeAnnotation')
+        .replace('StringLiteral', 'StringTypeAnnotation');
+    }
+
+    return 'StringTypeAnnotation';
+  }
+
+  isEnumDeclaration(maybeEnumDeclaration: $FlowFixMe): boolean {
+    return maybeEnumDeclaration.type === 'TSEnumDeclaration';
+  }
+
+  language(): ParserType {
+    return 'TypeScript';
+  }
+
   nameForGenericTypeAnnotation(typeAnnotation: $FlowFixMe): string {
     return typeAnnotation.typeName.name;
   }

packages/react-native-codegen/src/parsers/utils.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow strict-local
+ * @flow strict
  * @format
  */