fix: Escape special chars in enum name (#283)

Author: sschw

plugins/typescript/src/core/schemaToEnumDeclaration.test.ts

@@ -71,14 +71,20 @@ describe("schemaToTypeAliasDeclaration", () => {
   it("should generate valid enum with values that contains spaces", () => {
     const schema: SchemaObject = {
       type: "string",
-      enum: ["saimois", "bengal", "british shorthair"],
+      enum: [
+        "saimois",
+        "bengal",
+        "british shorthair",
+        "danish\u2013swedish farmdog",
+      ],
     };
 
     expect(printSchema(schema, "test")).toMatchInlineSnapshot(`
       "export enum Test {
           Saimois = "saimois",
           Bengal = "bengal",
-          BritishShorthair = "british shorthair"
+          BritishShorthair = "british shorthair",
+          "danish\\u2013swedish farmdog" = "danish\\u2013swedish farmdog"
       }"
     `);
   });

plugins/typescript/src/core/schemaToEnumDeclaration.ts

@@ -4,6 +4,30 @@ import ts, { factory as f } from "typescript";
 import { convertNumberToWord } from "../utils/getEnumProperties";
 import { Context, getJSDocComment } from "./schemaToTypeAliasDeclaration";
 
+/**
+ * Function to check if a string is a valid TypeScript identifier
+ *
+ * @param name Name to check
+ */
+function isValidIdentifier(name: string): boolean {
+  if (name.length === 0) {
+    return false;
+  }
+
+  const firstChar = name.charCodeAt(0);
+  if (!ts.isIdentifierStart(firstChar, ts.ScriptTarget.Latest)) {
+    return false;
+  }
+
+  for (let i = 1; i < name.length; i++) {
+    if (!ts.isIdentifierPart(name.charCodeAt(i), ts.ScriptTarget.Latest)) {
+      return false;
+    }
+  }
+
+  return true;
+}
+
 /**
  * Add Enum support when transforming an OpenAPI Schema Object to Typescript Nodes.
  *
@@ -52,8 +76,11 @@ function getEnumMembers(schema: SchemaObject): ts.EnumMember[] {
       throw new Error(`Unsupported enum value type: ${typeof enumValue}`);
     }
 
+    enumName = pascal(enumName);
     return f.createEnumMember(
-      f.createIdentifier(pascal(enumName)),
+      isValidIdentifier(enumName)
+        ? f.createIdentifier(enumName)
+        : f.createStringLiteral(`${enumValue}`),
       enumValueNode
     );
   });