Skip to content

fix(typescript): Fix enum string numbers handling #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabien0102 merged 1 commit into from
Jan 9, 2026
Merged

fix(typescript): Fix enum string numbers handling #327

fabien0102 merged 1 commit into from
Jan 9, 2026

Conversation

@sschw
Copy link
Contributor

@sschw sschw commented Jan 6, 2026 •
edited
Loading

TypeScript does not allow fully numeric string enum names, see example:

enum Test {
  "1"      = "1", // invalid
  "0"      = "0", // invalid
  "-1"     = "-1", // invalid
  "3.33"   = "3.33" // invalid
  // However
  "01"     = "01", // valid
  "00"     = "00", // valid
  "-01"    = "-01", // valid
  "1 Apple" = "1 Apple", // valid
}

Added a check to specifically only converting the valid numbers by their string representative.

enum Test {
  One = "1",
  Zero = "0",
  MinusOne = "-1",
  ThreePointThreeThree = "3.33"
  // However it keeps all valid once as is.
  "01"     = "01", 
  "00"     = "00", 
  "-01"    = "-01", 
  "1 Apple" = "1 Apple", 
}

Also added "minus " and " point [...]" to the convert function.

@sschw sschw force-pushed the fix-enum-string-numbers branch from 7936b87 to 32c84a4 Compare January 6, 2026 16:21
@fabien0102 fabien0102 merged commit bf87c14 into fabien0102:main Jan 9, 2026
1 check passed
@github-actions github-actions bot mentioned this pull request Jan 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabien0102 fabien0102 fabien0102 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sschw @fabien0102