Replace unicode emojis with standard exit codes for CLI validation.

Author: fabiocaccamo

src/codicefiscale/cli.py

@@ -43,11 +43,11 @@ def default_encoder(obj: Any) -> Any:
         sys.stdout.write(f"{cf_output}\n")
 
 
-def _validate_from_args(args: argparse.Namespace) -> None:
+def _validate_from_args(args: argparse.Namespace) -> int:
     if codicefiscale.is_valid(args.code):
-        sys.stdout.write("✅\n")
+        return 0
     else:
-        sys.stdout.write("❌\n")
+        return 1
 
 
 def run() -> None:
@@ -144,6 +144,6 @@ def run_with_args(args: argparse.Namespace) -> None:
     elif args.subcommand == "encode":
         _encode_from_args(args)
     elif args.subcommand == "validate":
-        _validate_from_args(args)
+        sys.exit(_validate_from_args(args))
     else:
         sys.stdout.write("For more info run: 'python -m codicefiscale --help'\n")

tests/test_cli.py

@@ -5,7 +5,7 @@
 from unittest import mock
 
 from codicefiscale import __version__
-from codicefiscale.cli import run, run_with_args
+from codicefiscale.cli import _validate_from_args, run, run_with_args
 
 
 def assert_command_output(command, expected_output):
@@ -588,32 +588,30 @@ def test_decode_with_wrong_code():
 
 
 def test_validate():
-    with mock.patch("sys.stdout", new=StringIO()) as fake_output:
-        args = argparse.Namespace(
-            code="RSSMRA90A01H501W",
-            subcommand="validate",
-        )
-        run_with_args(args)
-        output = fake_output.getvalue().strip()
-        assert output == "✅"
+    args = argparse.Namespace(
+        code="RSSMRA90A01H501W",
+        subcommand="validate",
+    )
+    exit_code = _validate_from_args(args)
+    assert exit_code == 0
 
 
 def test_validate_from_command_line():
     cmd = "python -m codicefiscale validate RSSMRA90A01H501W"
-    assert_command_output(cmd, "✅")
+    result = subprocess.run(cmd, shell=True)
+    assert result.returncode == 0
 
 
 def test_validate_with_wrong_code():
-    with mock.patch("sys.stdout", new=StringIO()) as fake_output:
-        args = argparse.Namespace(
-            code="RSSMRA90A01H501X",
-            subcommand="validate",
-        )
-        run_with_args(args)
-        output = fake_output.getvalue().strip()
-        assert output == "❌"
+    args = argparse.Namespace(
+        code="RSSMRA90A01H501X",
+        subcommand="validate",
+    )
+    exit_code = _validate_from_args(args)
+    assert exit_code == 1
 
 
 def test_validate_with_wrong_code_from_command_line():
     cmd = "python -m codicefiscale validate RSSMRA90A01H501X"
-    assert_command_output(cmd, "❌")
+    result = subprocess.run(cmd, shell=True)
+    assert result.returncode == 1