Various small fixes (#53)

* Fix crash on Windows

Without deleting the object the file stays locked preventing the removal of the temporary folder

* Correctly center text in get_image()

* Fix AttributeError in get_features()

Closes #50

* Set unicode_name default to None

Closes #51

* Check if chr() conversion is in acceptable range

Closes #52

* Add unit tests for issue 50, 51, 52

* Expose all TTFont arguments

* Fix typos in pull request template

* Fix get_fingerprint()

Author: seproDev

.github/pull_request_template.md

@@ -14,5 +14,5 @@ assignees: fabiocaccamo
 
 **Checklist before requesting a review**
 - [ ] I have performed a self-review of my code.
-- [ ] I have added torough tests for the proposed changes.
-- [ ] I have run the tests and there are not errors.
+- [ ] I have added thorough tests for the proposed changes.
+- [ ] I have run the tests and there are no errors.

fontbro/font.py

@@ -201,7 +201,7 @@ class Font:
     ]
     _WIDTHS_BY_VALUE = {width["value"]: width for width in _WIDTHS}
 
-    def __init__(self, filepath, lazy=False):
+    def __init__(self, filepath, **kwargs):
         """
         Constructs a new Font instance loading a font file from the given filepath.
 
@@ -213,22 +213,22 @@ def __init__(self, filepath, lazy=False):
         super().__init__()
 
         self._filepath = None
-        self._lazy = None
+        self._kwargs = None
         self._ttfont = None
 
         if isinstance(filepath, str):
-            self._init_with_filepath(filepath, lazy=lazy)
+            self._init_with_filepath(filepath, **kwargs)
         else:
             filepath_type = type(filepath).__name__
             raise ValueError(
                 f"Invalid filepath type: expected str, found '{filepath_type}'."
             )
 
-    def _init_with_filepath(self, filepath, lazy=False):
+    def _init_with_filepath(self, filepath, **kwargs):
         try:
             self._filepath = filepath
-            self._lazy = lazy
-            self._ttfont = TTFont(self._filepath, lazy=self._lazy)
+            self._kwargs = kwargs
+            self._ttfont = TTFont(self._filepath, **kwargs)
 
         except TTLibError:
             raise ValueError(f"Invalid font at filepath: '{filepath}'.")
@@ -243,7 +243,7 @@ def clone(self):
         """
         Creates a new Font instance reading the same binary file.
         """
-        return Font(self._filepath, lazy=self._lazy)
+        return Font(self._filepath, **self._kwargs)
 
     def close(self):
         """
@@ -271,17 +271,17 @@ def get_characters(self, ignore_blank=False):
         glyfs = font.get("glyf")
         for code, char_name in cmap.items():
             code_hex = f"{code:04X}"
-            char = chr(code)
+            if 0 <= code < 0x110000:
+                char = chr(code)
+            else:
+                continue
             if ascii.iscntrl(char):
                 continue
             if glyfs and ignore_blank:
                 glyf = glyfs.get(char_name)
                 if glyf and glyf.numberOfContours == 0:
                     continue
-            try:
-                unicode_name = unicodedata.name(char)
-            except ValueError:
-                pass
+            unicode_name = unicodedata.name(char, None)
             unicode_block_name = unicodedata.block(code)
             unicode_script_tag = unicodedata.script(code)
             unicode_script_name = unicodedata.script_name(unicode_script_tag)
@@ -337,7 +337,10 @@ def get_features_tags(self):
         for table_tag in ["GPOS", "GSUB"]:
             if table_tag in font:
                 table = font[table_tag].table
-                feature_record = table.FeatureList.FeatureRecord or []
+                try:
+                    feature_record = table.FeatureList.FeatureRecord or []
+                except AttributeError:
+                    feature_record = []
                 for feature in feature_record:
                     features_tags.add(feature.FeatureTag)
         return sorted(features_tags)
@@ -357,11 +360,11 @@ def get_fingerprint(self, text=""):
 
         text = text or "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"
 
-        img = self.get_image(text=text[0], size=72)
+        img = self.get_image(text=text, size=72)
         img_size = img.size
         img = img.resize((img_size[0] // 2, img_size[1] // 2))
         img = img.resize((img_size[0], img_size[1]), Image.Resampling.NEAREST)
-        img = img.quantize(colors=2)
+        img = img.quantize(colors=8)
         # img.show()
 
         hash = imagehash.average_hash(img, hash_size=64)
@@ -484,7 +487,8 @@ def get_image(
             img_size = (img_width, img_height)
             img = img.resize(img_size)
             draw = ImageDraw.Draw(img)
-            draw.text((0, 0), text, font=img_font, fill=color)
+            draw.text((-img_bbox[0], -img_bbox[1]), text, font=img_font, fill=color)
+            del img_font
             return img
 
     def get_italic_angle(self):

tests/fonts/issues/issue-0050/LeagueGothic-Regular.otf

@@ -11,3 +11,18 @@ def test_issue_0048_get_characters_count(self):
         font = self._get_font("/issues/issue-0048/test.ttf")
         with self.assertRaises(TypeError):
             font.get_characters_count()
+
+    def test_issue_0050_get_features(self):
+        font = self._get_font("/issues/issue-0050/LeagueGothic-Regular.otf")
+        features = font.get_features_tags()
+        self.assertEqual(features, ["kern"])
+
+    def test_issue_0051_get_characters_count(self):
+        font = self._get_font("/issues/issue-0051/ANASTCN.ttf")
+        chars_count = font.get_characters_count()
+        self.assertEqual(chars_count, 212)
+
+    def test_issue_0052_get_characters_count(self):
+        font = self._get_font("/issues/issue-0052/Bobbiefreebie.ttf")
+        chars_count = font.get_characters_count()
+        self.assertEqual(chars_count, 288)