Don't redefine built-ins.

Author: fabiocaccamo

fsutil/info.py

@@ -40,13 +40,13 @@ def get_dir_hash(path: PathIn, *, func: str = "md5") -> str:
     """
     path = _get_path(path)
     assert_dir(path)
-    hash = hashlib.new(func)
+    hash_ = hashlib.new(func)
     files = search_files(path)
     for file in sorted(files):
         file_hash = get_file_hash(file, func=func)
         file_hash_b = bytes(file_hash, "utf-8")
-        hash.update(file_hash_b)
-    hash_hex = hash.hexdigest()
+        hash_.update(file_hash_b)
+    hash_hex = hash_.hexdigest()
     return hash_hex
 
 

fsutil/operations.py

@@ -413,7 +413,7 @@ def rename_file(path: PathIn, name: str) -> None:
     """
     path = _get_path(path)
     assert_file(path)
-    dirpath, filename = split_filepath(path)
+    dirpath, _ = split_filepath(path)
     dest = join_filepath(dirpath, name)
     assert_not_exists(dest)
     os.rename(path, dest)

tests/test_info.py

@@ -50,8 +50,8 @@ def test_get_dir_hash(temp_path):
     fsutil.create_file(f4_path, content="hello world 4")
     fsutil.create_file(f5_path, content="hello world 5")
     fsutil.create_file(f6_path, content="hello world 6")
-    hash = fsutil.get_dir_hash(temp_path("x/"))
-    assert hash == "eabe619c41f0c4611b7b9746bededfcb"
+    dir_hash = fsutil.get_dir_hash(temp_path("x/"))
+    assert dir_hash == "eabe619c41f0c4611b7b9746bededfcb"
 
 
 def test_get_dir_last_modified_date(temp_path):
@@ -123,8 +123,8 @@ def test_get_file_creation_date_formatted(temp_path):
 def test_get_file_hash(temp_path):
     path = temp_path("a/b/c.txt")
     fsutil.create_file(path, content="Hello World")
-    hash = fsutil.get_file_hash(path)
-    assert hash == "b10a8db164e0754105b7a99be72e3fe5"
+    file_hash = fsutil.get_file_hash(path)
+    assert file_hash == "b10a8db164e0754105b7a99be72e3fe5"
 
 
 def test_get_file_last_modified_date(temp_path):