Skip to content

Commit 10eb65b

Browse files
dbrattliclaude
andauthored
fix: relax FSharp.Core dependency to >= 5.0.0 (#163)
* fix: relax FSharp.Core dependency to >= 5.0.0 Use lowest_matching: true to resolve FSharp.Core to the minimum version (5.0.0) instead of the latest (10.0.100). This fixes NU1605 version conflicts for users on .NET 6, 8, or 9. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> * ci: Fix uv install --------- Co-authored-by: Claude Opus 4.5 <[email protected]>
1 parent 81f825c commit 10eb65b

File tree

6 files changed

+16
-9
lines changed

6 files changed

+16
-9
lines changed

.github/workflows/build-and-test.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,16 @@ jobs:
2727
- name: Install just
2828
uses: extractions/setup-just@v3
2929

30+
- name: Install uv
31+
run: pipx install uv
32+
3033
- name: Restore dependencies
31-
run: just restore
34+
run: |
35+
just setup
36+
just restore
3237
3338
- name: Install Python dependencies
3439
run: |
35-
pipx install uv
3640
just install-python
3741
3842
#- name: Check formatting

examples/fastapi/FastApi.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project Sdk="Microsoft.NET.Sdk">
33
<PropertyGroup>
4-
<TargetFramework>net9.0</TargetFramework>
4+
<TargetFramework>net10.0</TargetFramework>
55
<OutputType>Exe</OutputType>
66
</PropertyGroup>
77
<ItemGroup>

justfile

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ clean-all: clean
3535
# Build F# source to Python using Fable
3636
build: clean
3737
mkdir -p {{build_path}}
38+
dotnet build {{src_path}}
3839
{{fable}} {{src_path}} --lang Python --outDir {{build_path}}
3940

4041
# Compile F# source using dotnet (without Fable transpilation)
@@ -79,9 +80,13 @@ format-check:
7980
dotnet fantomas {{src_path}} -r --check
8081
dotnet fantomas {{test_path}} -r --check
8182

83+
# Install .NET tools (Fable, Fantomas) and Python dependencies
84+
setup:
85+
dotnet tool restore
86+
uv sync
87+
8288
# Restore all dependencies
8389
restore:
84-
dotnet tool restore
8590
dotnet paket install
8691
dotnet restore {{src_path}}
8792
dotnet restore {{test_path}}
@@ -90,9 +95,6 @@ restore:
9095
install-python:
9196
uv sync
9297

93-
# Full setup: restore .NET and Python dependencies
94-
setup: restore install-python
95-
9698
# Watch for changes and rebuild (useful during development)
9799
watch:
98100
{{fable}} watch {{src_path}} --lang Python --outDir {{build_path}}

paket.dependencies

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ source https://api.nuget.org/v3/index.json
44
storage: none
55
framework: netstandard2.0, netstandard2.1, net6.0, net8.0, net9.0, net10.0
66

7+
nuget FSharp.Core >= 5.0.0 lowest_matching: true
78
nuget Fable.Core 5.0.0-beta.4
89

910
group Test

paket.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ NUGET
44
remote: https://api.nuget.org/v3/index.json
55
Fable.Core (5.0.0-beta.4)
66
FSharp.Core (>= 4.7.2)
7-
FSharp.Core (10.0.100)
7+
FSharp.Core (5.0)
88

99
GROUP Examples
1010
STORAGE: NONE

release-please-config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"packages": {
44
".": {
55
"release-type": "simple",
6-
"release-as": "5.0.0-alpha.20",
6+
"release-as": "5.0.0-alpha.20.1",
77
"bump-minor-pre-major": true,
88
"bump-patch-for-minor-pre-major": true,
99
"include-component-in-tag": false,

0 commit comments

Comments
 (0)