Skip to content

Commit fdfd7a8

Browse files
forkialfonsogarciacaro
authored andcommitted
use hashset instead of F# sets
1 parent 8f3efdd commit fdfd7a8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/Fable.React/Fable.Helpers.ReactServer.fs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ open Fable.Helpers.React
99
open Fable.Helpers.React.Props
1010

1111
// Adapted from https://github.com/emotion-js/emotion/blob/182e34bab2b2028c96d513b67ed86faee1b642b2/packages/emotion-utils/src/index.js#L13
12-
let private unitlessCssProps = set [ "animation-iteration-count"; "border-image-outset"; "border-image-slice"; "border-image-width"; "box-flex"; "box-flex-group"; "box-ordinal-group"; "column-count"; "columns"; "flex"; "flex-grow"; "flex-positive"; "flex-shrink"; "flex-negative"; "flex-order"; "grid-row"; "grid-row-end"; "grid-row-span"; "grid-row-start"; "grid-column"; "grid-column-end"; "grid-column-span"; "grid-column-start"; "font-weight"; "line-height"; "opacity"; "order"; "orphans"; "tab-size"; "widows"; "z-index"; "zoom"; "-webkit-line-clamp"; "fill-opacity"; "flood-opacity"; "stop-opacity"; "stroke-dasharray"; "stroke-dashoffset"; "stroke-miterlimit"; "stroke-opacity"; "stroke-width" ]
12+
let private unitlessCssProps = System.Collections.Generic.HashSet<_>([ "animation-iteration-count"; "border-image-outset"; "border-image-slice"; "border-image-width"; "box-flex"; "box-flex-group"; "box-ordinal-group"; "column-count"; "columns"; "flex"; "flex-grow"; "flex-positive"; "flex-shrink"; "flex-negative"; "flex-order"; "grid-row"; "grid-row-end"; "grid-row-span"; "grid-row-start"; "grid-column"; "grid-column-end"; "grid-column-span"; "grid-column-start"; "font-weight"; "line-height"; "opacity"; "order"; "orphans"; "tab-size"; "widows"; "z-index"; "zoom"; "-webkit-line-clamp"; "fill-opacity"; "flood-opacity"; "stop-opacity"; "stroke-dasharray"; "stroke-dashoffset"; "stroke-miterlimit"; "stroke-opacity"; "stroke-width" ])
1313

14-
let private voidTags = set ["area"; "base"; "br"; "col"; "embed"; "hr"; "img"; "input"; "keygen"; "link"; "menuitem"; "meta"; "param"; "source"; "track"; "wbr"]
14+
let private voidTags = System.Collections.Generic.HashSet<_>(["area"; "base"; "br"; "col"; "embed"; "hr"; "img"; "input"; "keygen"; "link"; "menuitem"; "meta"; "param"; "source"; "track"; "wbr"])
1515

1616
// Adapted from https://github.com/facebook/react/blob/37e4329bc81def4695211d6e3795a654ef4d84f5/packages/react-dom/src/server/escapeTextForBrowser.js#L49
1717
let escapeHtml (str: string) =
@@ -36,9 +36,9 @@ let escapeHtml (str: string) =
3636
escaped.ToString()
3737

3838
let inline private addUnit (key: string) (value: string) =
39-
if unitlessCssProps |> Set.contains key |> not
40-
then value + "px"
41-
else value
39+
if unitlessCssProps.Contains key
40+
then vaule
41+
else value + "px"
4242

4343
let private cssProp (key: string) (value: obj) =
4444
let value =
@@ -743,7 +743,7 @@ let renderToString (htmlNode: ReactElement): string =
743743
| Some c -> c
744744
| None -> (renderList (children |> Seq.map castHTMLNode))
745745
let attrs = if attrs = "" then attrs else " " + attrs
746-
if voidTags |> Set.contains tag
746+
if voidTags.Contains tag
747747
then "<" + tag + attrs + "/>"
748748
else "<" + tag + attrs + ">" + child + "</" + tag + ">"
749749
| HTMLNode.List nodes -> renderList (nodes |> Seq.cast)

0 commit comments

Comments
 (0)