-
Notifications
You must be signed in to change notification settings - Fork 3
Description
I find the names driverJourney and passengerJourney somewhat confusing, and I would like your input before proposing a PR.
Especially, when we look at a DriverJourney object (or more specifically its DriverTrip component), we see attributes like departureToPickupWalkingDistance, which is especially confusing as at first we expect informations about a driver and not a walker given the name.
I suggest searching for better names. The best I could come up with is:
DriverJourney->JourneyAsPassengerPassengerJourney->JourneyWithPassenger
EDIT: I also wonder why \driver_regular_trips endpoint is not called \driver_regular_journeys. (Especially as *Journey = *Trip + JourneySchedule, I would expect *RegularJourney = *Trip + Schedules).
Is there a rationale behind the change in vocabulary? Maybe because regular trips are more likely to be round trips than single journeys? or is it common business vocabulary?
2nd EDIT: By writing the spec, I realize that considering that a regular trip can be composed of individual Journeys is pretty useful, so I think I've got it.