Fix #1715: ApplyService#applyProjectRequest should be (truly) idempotent

Author: rohanKanojia

CHANGELOG.md

@@ -24,6 +24,7 @@ After this we will switch probably to real [Semantic Versioning 2.0.0](http://se
 * Fix #1704: fabric8-build failing on openshift
 * Fix #1714: resource-goal converts types of kubernetes YAML annotations in fragment
 * Feature #1706: Prometheus Enricher; Configuration support for Prometheus path
+* Fix #1715: ApplyService#applyProjectRequest should be (truly) idempotent
 * Added generator support for Open Liberty
 
 ### 4.2.0 (01-08-2019)

core/src/main/java/io/fabric8/maven/core/service/ApplyService.java

@@ -70,9 +70,11 @@
 import java.net.HttpURLConnection;
 import java.nio.charset.Charset;
 import java.util.ArrayList;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.Set;
 
 import static io.fabric8.maven.core.util.kubernetes.KubernetesHelper.getKind;
 import static io.fabric8.maven.core.util.kubernetes.KubernetesHelper.getName;
@@ -102,6 +104,8 @@ public class ApplyService {
     private boolean rollingUpgradePreserveScale = true;
     private boolean recreateMode;
     private PatchService patchService;
+    // This map is to track projects created.
+    private static Set<String> projectsCreated = new HashSet<>();
 
     public ApplyService(KubernetesClient kubernetesClient, Logger log) {
         this.kubernetesClient = kubernetesClient;
@@ -1090,6 +1094,10 @@ public boolean applyProject(Project project) {
      * Returns true if the ProjectRequest is created
      */
     public boolean applyProjectRequest(ProjectRequest entity) {
+        // Check whether project creation attempted before
+        if (projectsCreated.contains(getName(entity))) {
+            return false;
+        }
         String namespace = getOrCreateMetadata(entity).getName();
         log.info("Using project: " + namespace);
         String name = getName(entity);
@@ -1100,10 +1108,11 @@ public boolean applyProjectRequest(ProjectRequest entity) {
             return false;
         }
         boolean exists = checkNamespace(name);
-        // We may want to be more fine-grained on the phase of the project
         if (!exists) {
             try {
                 Object answer = openshiftClient.projectrequests().create(entity);
+                // Add project to created projects
+                projectsCreated.add(name);
                 logGeneratedEntity("Created ProjectRequest: ", namespace, entity, answer);
                 return true;
             } catch (Exception e) {