Skip to content

Commit 04c4d2c

Browse files
authored
fix(openapi): knative VolatileTime should be serialized as String
Signed-off-by: Marc Nuri <[email protected]>
1 parent e16f208 commit 04c4d2c

File tree

4 files changed

+12
-128
lines changed

4 files changed

+12
-128
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
#### Bugs
66
* Fix #6892: rolling().restart() doesn't remove preexistent pod template annotations
7+
* Fix #6906: Knative VolatileTime should be serialized as String
78

89
#### Improvements
910
* Fix #6863: ensuring SerialExecutor does not throw RejectedExecutionException to prevent unnecessary error logs

extensions/knative/model/pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,15 @@
7070
</includeGenerationRegexes>
7171
<skipGenerationRegexes>
7272
<skipGenerationRegex>^dev\.knative\.pkg\.apis\.URL$</skipGenerationRegex>
73+
<skipGenerationRegex>^dev\.knative\.pkg\.apis\.VolatileTime$</skipGenerationRegex>
7374
<skipGenerationRegex>^dev\.knative\.duck\.v1alpha1\.PlaceableList$</skipGenerationRegex>
7475
</skipGenerationRegexes>
76+
<refToJavaTypeMappings>
77+
<property>
78+
<name>#/components/schemas/dev.knative.pkg.apis.VolatileTime</name>
79+
<value>java.lang.String</value>
80+
</property>
81+
</refToJavaTypeMappings>
7582
</settings>
7683
</configuration>
7784
</plugin>

extensions/knative/model/src/generated/java/io/fabric8/knative/pkg/apis/Condition.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public class Condition implements Editable<ConditionBuilder>, KubernetesResource
7171
{
7272

7373
@JsonProperty("lastTransitionTime")
74-
private VolatileTime lastTransitionTime;
74+
private String lastTransitionTime;
7575
@JsonProperty("message")
7676
private String message;
7777
@JsonProperty("reason")
@@ -91,7 +91,7 @@ public class Condition implements Editable<ConditionBuilder>, KubernetesResource
9191
public Condition() {
9292
}
9393

94-
public Condition(VolatileTime lastTransitionTime, String message, String reason, String severity, String status, String type) {
94+
public Condition(String lastTransitionTime, String message, String reason, String severity, String status, String type) {
9595
super();
9696
this.lastTransitionTime = lastTransitionTime;
9797
this.message = message;
@@ -105,15 +105,15 @@ public Condition(VolatileTime lastTransitionTime, String message, String reason,
105105
* Condition defines a readiness condition for a Knative resource. See: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties
106106
*/
107107
@JsonProperty("lastTransitionTime")
108-
public VolatileTime getLastTransitionTime() {
108+
public String getLastTransitionTime() {
109109
return lastTransitionTime;
110110
}
111111

112112
/**
113113
* Condition defines a readiness condition for a Knative resource. See: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties
114114
*/
115115
@JsonProperty("lastTransitionTime")
116-
public void setLastTransitionTime(VolatileTime lastTransitionTime) {
116+
public void setLastTransitionTime(String lastTransitionTime) {
117117
this.lastTransitionTime = lastTransitionTime;
118118
}
119119

extensions/knative/model/src/generated/java/io/fabric8/knative/pkg/apis/VolatileTime.java

Lines changed: 0 additions & 124 deletions
This file was deleted.

0 commit comments

Comments
 (0)