fix #5100: lessening the level of the non-conflicting warning

Author: shawkins

CHANGELOG.md

@@ -6,6 +6,7 @@
 * Fix #5102: wait on scale to 0 was not completing
 
 #### Improvements
+* Fix #5100: lessened the level of the non-conflicting httpclient implementation warning
 
 #### Dependency Upgrade
 

kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/utils/HttpClientUtils.java

@@ -30,14 +30,15 @@
 import java.net.URL;
 import java.nio.charset.StandardCharsets;
 import java.time.Instant;
+import java.util.ArrayList;
 import java.util.Base64;
-import java.util.HashSet;
+import java.util.Collections;
 import java.util.LinkedHashMap;
+import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 import java.util.Optional;
 import java.util.ServiceLoader;
-import java.util.Set;
 import java.util.concurrent.TimeUnit;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -150,37 +151,25 @@ public static HttpClient.Factory getHttpClientFactory() {
   }
 
   private static HttpClient.Factory getFactory(ServiceLoader<HttpClient.Factory> loader) {
-    HttpClient.Factory selected = null;
-    Set<String> detectedFactories = new HashSet<>();
-    Set<String> samePriority = new HashSet<>();
-    for (HttpClient.Factory candidate : loader) {
-      final String candidateClassName = candidate.getClass().getName();
-      detectedFactories.add(candidateClassName);
-      LOGGER.debug("Considering {} httpclient factory", candidateClassName);
-
-      if (selected == null) {
-        selected = candidate;
-        LOGGER.debug("Temporarily selected {} as first candidate httpclient factory", candidateClassName);
-      } else if (selected.priority() < candidate.priority()) {
-        selected = candidate;
-        samePriority.clear();
-        LOGGER.debug("Temporarily selected {} as httpclient factory, replacing one with lower priority",
-            candidateClassName);
-      } else if (selected.priority() == candidate.priority()) {
-        samePriority.add(candidateClassName);
-      } else {
-        LOGGER.debug("Ignoring {} httpclient factory as it doesn't supersede currently selected one", candidateClassName);
-      }
-
+    List<HttpClient.Factory> factories = new ArrayList<>();
+    loader.forEach(factories::add);
+    if (factories.isEmpty()) {
+      return null;
     }
-
-    if (detectedFactories.size() > 1) {
-      LOGGER.warn("The following httpclient factories were detected on your classpath: {}, "
-          + (samePriority.isEmpty() ? "" : "{} of which had the same priority ({}) so one was chosen randomly. ")
-          + "You should exclude dependencies that aren't needed or use an explicit association of the HttpClient.Factory.",
-          detectedFactories, samePriority.size(), samePriority);
+    Collections.sort(factories, (f1, f2) -> Integer.compare(f2.priority(), f1.priority()));
+    HttpClient.Factory factory = factories.get(0);
+    if (factories.size() > 1) {
+      if (factories.get(1).priority() == factory.priority()) {
+        LOGGER.warn("The following httpclient factories were detected on your classpath: {}, "
+            + "multiple of which had the same priority ({}) so one was chosen randomly. "
+            + "You should exclude dependencies that aren't needed or use an explicit association of the HttpClient.Factory.",
+            factories.stream().map(f -> f.getClass().getName()).toArray(), factory.priority());
+      } else if (LOGGER.isDebugEnabled()) {
+        LOGGER.debug("The following httpclient factories were detected on your classpath: {}",
+            factories.stream().map(f -> f.getClass().getName()).toArray());
+      }
     }
-    return selected;
+    return factory;
   }
 
   public static void applyCommonConfiguration(Config config, HttpClient.Builder builder, HttpClient.Factory factory) {

kubernetes-client-api/src/test/java/io/fabric8/kubernetes/client/utils/HttpClientUtilsTest.java

@@ -31,6 +31,7 @@
 import org.junit.jupiter.params.provider.MethodSource;
 import org.junit.jupiter.params.provider.ValueSource;
 import org.mockito.MockedStatic;
+import org.mockito.Mockito;
 
 import java.net.MalformedURLException;
 import java.net.URL;
@@ -215,6 +216,7 @@ void setUp() {
       mockedStaticServiceLoader = mockStatic(ServiceLoader.class);
       @SuppressWarnings("unchecked")
       final ServiceLoader<HttpClient.Factory> mockServiceLoader = mock(ServiceLoader.class);
+      Mockito.doCallRealMethod().when(mockServiceLoader).forEach(Mockito.any());
       when(mockServiceLoader.iterator()).thenAnswer(i -> new ArrayList<>(factories).iterator());
       when(ServiceLoader.load(eq(HttpClient.Factory.class), any())).thenReturn(mockServiceLoader);
       mockedStaticServiceLoader.when(() -> ServiceLoader.load(eq(HttpClient.Factory.class)))