Commit 29ff211
fix(httpclient): correct factory priorities and add Vert.x 5 runtime validation (7442)
fix(httpclient): correct HTTP client factory priorities
VertxHttpClientFactory is now the default HTTP client but was missing
the priority -1 that indicates it's the project default. OkHttpClientFactory
was still using priority -1 from when it was the default.
This fix:
- Adds priority() returning -1 to VertxHttpClientFactory (new default)
- Removes priority() override from OkHttpClientFactory (now uses default 0)
This ensures deterministic factory selection when multiple HTTP clients
are on the classpath - the default Vert.x client will always be preferred
unless a higher priority client is present.
Fixes #7174
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
fix(httpclient-vertx-5): add runtime check and documentation for Vert.x version compatibility
Add runtime validation in Vertx5HttpClientFactory.newBuilder() to detect
when Vert.x 5 classes are not available on the classpath.
This provides a clear error message instead of cryptic NoClassDefFoundError
when both kubernetes-httpclient-vertx (Vert.x 4) and kubernetes-httpclient-vertx-5
(Vert.x 5) are present but Maven resolves Vert.x 4 JARs.
Also add detailed documentation in CHANGELOG explaining:
- The mutual exclusivity of the two Vert.x HTTP client modules
- How to properly configure Vert.x 5 with exclusions and property override
- The root cause of the classpath conflict
Fixes #7174
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>1 parent 4db093a commit 29ff211
File tree
4 files changed
+82
-6
lines changed- httpclient-okhttp/src/main/java/io/fabric8/kubernetes/client/okhttp
- httpclient-vertx-5/src/main/java/io/fabric8/kubernetes/client/vertx5
- httpclient-vertx/src/main/java/io/fabric8/kubernetes/client/vertx
4 files changed
+82
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
7 | 10 | | |
8 | 11 | | |
9 | 12 | | |
| |||
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
19 | 58 | | |
20 | 59 | | |
21 | 60 | | |
| |||
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 30 | | |
36 | 31 | | |
37 | 32 | | |
| |||
Lines changed: 38 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
29 | 36 | | |
30 | 37 | | |
31 | 38 | | |
| 39 | + | |
| 40 | + | |
32 | 41 | | |
33 | 42 | | |
34 | 43 | | |
| |||
53 | 62 | | |
54 | 63 | | |
55 | 64 | | |
| 65 | + | |
| 66 | + | |
56 | 67 | | |
57 | 68 | | |
58 | 69 | | |
| 70 | + | |
59 | 71 | | |
60 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
61 | 98 | | |
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
| |||
0 commit comments