Skip to content

Commit 6498e28

Browse files
rohanKanojiamanusa
authored andcommitted
fix (kubernetes-model-generator/pkg/schemagen) : Remove check to convert integer array to string
Kubernetes Model Generator script currently converted all byte, integer lists to string (since there is no byte reflect.type in GoLang , it's alias to `uint8`). This seems to be incorrectly generating PodFailurePolicyOnExitCodesRequirement.values field as String. Add a switch case in `javaType()` to treat `reflect.Uint8` to byte. Limit `javaTypeArrayList()` to only convert byte array/ `reflect.Uint8` array to string. Signed-off-by: Rohan Kumar <[email protected]>
1 parent c81c937 commit 6498e28

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

kubernetes-model-generator/pkg/schemagen/generate.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func (g *schemaGenerator) generateReference(t reflect.Type) string {
128128
func (g *schemaGenerator) javaTypeArrayList(t reflect.Type) string {
129129
typeName := g.javaTypeWrapPrimitive(t)
130130
switch typeName {
131-
case "Byte", "Integer":
131+
case "Byte":
132132
return "String"
133133
default:
134134
return "java.util.ArrayList<" + typeName + ">"
@@ -193,9 +193,11 @@ func (g *schemaGenerator) javaType(t reflect.Type) string {
193193
switch t.Kind() {
194194
case reflect.Bool:
195195
return "bool"
196+
case reflect.Uint8:
197+
return "Byte"
196198
case reflect.Int, reflect.Int8, reflect.Int16,
197199
reflect.Int32, reflect.Uint,
198-
reflect.Uint8, reflect.Uint16, reflect.Uint32:
200+
reflect.Uint16, reflect.Uint32:
199201
return "int"
200202
case reflect.Int64, reflect.Uint64:
201203
return "Long"

0 commit comments

Comments
 (0)