[java-generator] Deprecate configuration options identified for removal

Author: andreaTP

CHANGELOG.md

@@ -63,6 +63,9 @@
   - JSON patch methods using an item for the diff generation such as edit or patch will no longer omit the resourceVersion in the patch.  If you want the patch to be unlocked, then set the resourceVersion to null on the item to be patched.
   - internal logic to mimic an apply that modify an item prior to a JSON patch is deprecated - you should instead build the item to be patched off of base version, such as with the edit method.
 
+#### _**Note**_: Deprecations
+* Fix #4875: Deprecated all the java-generator options identified for deletion in a following release
+
 ### 6.4.1 (2023-01-31)
 
 #### Bugs

java-generator/cli/src/main/java/io/fabric8/java/generator/cli/GenerateJavaSources.java

@@ -55,13 +55,17 @@ public class GenerateJavaSources implements Runnable {
   @Option(names = { "-enum-uppercase", "--enum-uppercase" }, description = "Uppercase the enum values", required = false)
   Boolean uppercaseEnum = null;
 
+  @Deprecated
   @Option(names = { "-prefix-strategy",
       "--prefix-strategy" }, description = "The prefix strategy to be used", required = false, hidden = true)
   String prefixStrategy = null;
 
-  @Option(names = { "-suffix-strategy", "--suffix-strategy" }, description = "The suffix strategy to be used", required = false)
+  @Deprecated
+  @Option(names = { "-suffix-strategy",
+      "--suffix-strategy" }, description = "The suffix strategy to be used", required = false, hidden = true)
   String suffixStrategy = null;
 
+  @Deprecated
   @Option(names = { "-always-preserve-unknown",
       "--always-preserve-unknown" }, description = "Always preserve unknown fields in the generated classes", required = false, hidden = true)
   Boolean alwaysPreserveUnkownFields = null;
@@ -70,6 +74,7 @@ public class GenerateJavaSources implements Runnable {
       "--add-extra-annotations" }, description = "Add extra lombok and sundrio annotation to the generated classes", required = false)
   Boolean addExtraAnnotations = null;
 
+  @Deprecated
   @Option(names = { "-code-structure",
       "--code-structure" }, description = "Generate classes using a specific layout", required = false, hidden = true)
   String codeStructure = null;

java-generator/core/src/main/java/io/fabric8/java/generator/Config.java

@@ -51,10 +51,14 @@ public enum Suffix {
   private static final Map<String, String> DEFAULT_PACKAGE_OVERRIDES = new HashMap<>();
 
   private Boolean uppercaseEnums = DEFAULT_UPPERCASE_ENUM;
+  @Deprecated
   private Prefix prefixStrategy = DEFAULT_PREFIX_STRATEGY;
+  @Deprecated
   private Suffix suffixStrategy = DEFAULT_SUFFIX_STRATEGY;
+  @Deprecated
   private Boolean alwaysPreserveUnknownFields = DEFAULT_ALWAYS_PRESERVE_FIELDS;
   private Boolean objectExtraAnnotations = DEFAULT_ADD_EXTRA_ANNOTATIONS;
+  @Deprecated
   private CodeStructure structure = DEFAULT_CODE_STRUCTURE;
   private Boolean generatedAnnotations = DEFAULT_ADD_GENERATED_ANNOTATIONS;
   private Map<String, String> packageOverrides = DEFAULT_PACKAGE_OVERRIDES;

java-generator/maven-plugin/src/main/java/io/fabric8/java/generator/maven/plugin/JavaGeneratorMojo.java

@@ -74,23 +74,26 @@ public class JavaGeneratorMojo extends AbstractMojo {
   Boolean enumUppercase = null;
 
   /**
-   * *advanced* The prefix strategy for name mangling
+   * *DEPRECATED* The prefix strategy for name mangling
    *
    */
+  @Deprecated
   @Parameter(property = "fabric8.java-generator.prefix-strategy", required = false)
   Config.Prefix prefixStrategy = null;
 
   /**
-   * *advanced* The suffix strategy for name mangling
+   * *DEPRECATED* The suffix strategy for name mangling
    *
    */
+  @Deprecated
   @Parameter(property = "fabric8.java-generator.suffix-strategy", required = false)
   Config.Suffix suffixStrategy = null;
 
   /**
-   * *advanced* Always inject additional properties in the generated classes
+   * *DEPRECATED* Always inject additional properties in the generated classes
    *
    */
+  @Deprecated
   @Parameter(property = "fabric8.java-generator.always-preserve-unknown", required = false)
   Boolean alwaysPreserveUnknown = null;
 
@@ -102,9 +105,10 @@ public class JavaGeneratorMojo extends AbstractMojo {
   Boolean extraAnnotations = null;
 
   /**
-   * *advanced* The code structure to be used when generating java sources
+   * *DEPRECATED* The code structure to be used when generating java sources
    *
    */
+  @Deprecated
   @Parameter(property = "fabric8.java-generator.code-structure", required = false)
   protected Config.CodeStructure codeStructure = null;