Skip to content

Commit 9529f1d

Browse files
committed
test(crd-generator): ensure Collection properties work like List in CRD generation
- Updated `ServiceSpec` to use `Collection` instead of `List` for `loadBalancerSourceRanges`. - Modified getter and setter methods for `loadBalancerSourceRanges` to use `Collection`. - Confirmed that CRD generation produces a field of type array when using `Collection`, ensuring compatibility and correct schema output. Signed-off-by: Sun Seng David TAN <[email protected]>
1 parent 6f4f529 commit 9529f1d

File tree

1 file changed

+4
-3
lines changed
  • crd-generator/api-v2/src/test/java/io/fabric8/crdv2/example/complex/k8s

1 file changed

+4
-3
lines changed

crd-generator/api-v2/src/test/java/io/fabric8/crdv2/example/complex/k8s/ServiceSpec.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import io.fabric8.kubernetes.api.model.KubernetesResource;
2525

2626
import java.util.ArrayList;
27+
import java.util.Collection;
2728
import java.util.LinkedHashMap;
2829
import java.util.List;
2930
import java.util.Map;
@@ -88,7 +89,7 @@ public class ServiceSpec implements KubernetesResource {
8889
private String loadBalancerIP;
8990
@JsonProperty("loadBalancerSourceRanges")
9091
@JsonInclude(JsonInclude.Include.NON_EMPTY)
91-
private List<String> loadBalancerSourceRanges = new ArrayList<>();
92+
private Collection<String> loadBalancerSourceRanges = new ArrayList<>();
9293
@JsonProperty("publishNotReadyAddresses")
9394
private Boolean publishNotReadyAddresses;
9495
@JsonProperty("selector")
@@ -225,12 +226,12 @@ public void setLoadBalancerIP(String loadBalancerIP) {
225226
}
226227

227228
@JsonProperty("loadBalancerSourceRanges")
228-
public List<String> getLoadBalancerSourceRanges() {
229+
public Collection<String> getLoadBalancerSourceRanges() {
229230
return loadBalancerSourceRanges;
230231
}
231232

232233
@JsonProperty("loadBalancerSourceRanges")
233-
public void setLoadBalancerSourceRanges(List<String> loadBalancerSourceRanges) {
234+
public void setLoadBalancerSourceRanges(Collection<String> loadBalancerSourceRanges) {
234235
this.loadBalancerSourceRanges = loadBalancerSourceRanges;
235236
}
236237

0 commit comments

Comments
 (0)