fix: RollableScalableResourceOperation.withReplicas uses manual Patch operations

Signed-off-by: Marc Nuri <[email protected]>

Author: manusa

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/DeploymentOperationsImpl.java

@@ -105,11 +105,6 @@ public RollingUpdater<Deployment, DeploymentList> getRollingUpdater(long rolling
     return null;
   }
 
-  @Override
-  public Deployment withReplicas(int count) {
-    return accept(d -> d.getSpec().setReplicas(count));
-  }
-
   @Override
   public int getCurrentReplicas(Deployment current) {
     return current.getStatus().getReplicas();

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/ReplicaSetOperationsImpl.java

@@ -69,11 +69,6 @@ public ReplicaSetOperationsImpl newInstance(PodOperationContext context,
     return new ReplicaSetOperationsImpl(context, superContext);
   }
 
-  @Override
-  public ReplicaSet withReplicas(int count) {
-    return accept(r -> r.getSpec().setReplicas(count));
-  }
-
   @Override
   public RollingUpdater<ReplicaSet, ReplicaSetList> getRollingUpdater(long rollingTimeout, TimeUnit rollingTimeUnit) {
     return new ReplicaSetRollingUpdater(context.getClient(), getNamespace(), rollingTimeUnit.toMillis(rollingTimeout),

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/RollableScalableResourceOperation.java

@@ -26,6 +26,8 @@
 import io.fabric8.kubernetes.client.dsl.Resource;
 import io.fabric8.kubernetes.client.dsl.RollableScalableResource;
 import io.fabric8.kubernetes.client.dsl.TimeoutImageEditReplacePatchable;
+import io.fabric8.kubernetes.client.dsl.base.PatchContext;
+import io.fabric8.kubernetes.client.dsl.base.PatchType;
 import io.fabric8.kubernetes.client.dsl.internal.HasMetadataOperation;
 import io.fabric8.kubernetes.client.dsl.internal.OperationContext;
 import io.fabric8.kubernetes.client.dsl.internal.PodOperationContext;
@@ -57,7 +59,10 @@ protected RollableScalableResourceOperation(PodOperationContext context, Operati
     this.rollingOperationContext = context;
   }
 
-  protected abstract T withReplicas(int count);
+  protected final T withReplicas(int count) {
+    return patch(PatchContext.of(PatchType.JSON),
+        "[{\"op\": \"replace\", \"path\":\"/spec/replicas\", \"value\":" + count + "}]");
+  }
 
   protected abstract RollingUpdater<T, L> getRollingUpdater(long rollingTimeout, TimeUnit rollingTimeUnit);
 

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/apps/v1/StatefulSetOperationsImpl.java

@@ -73,11 +73,6 @@ public StatefulSetOperationsImpl newInstance(PodOperationContext context,
     return new StatefulSetOperationsImpl(context, superContext);
   }
 
-  @Override
-  public StatefulSet withReplicas(int count) {
-    return accept(s -> s.getSpec().setReplicas(count));
-  }
-
   @Override
   public RollingUpdater<StatefulSet, StatefulSetList> getRollingUpdater(long rollingTimeout, TimeUnit rollingTimeUnit) {
     return null;

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/ReplicationControllerOperationsImpl.java

@@ -70,11 +70,6 @@ public ReplicationControllerOperationsImpl newInstance(PodOperationContext conte
     return new ReplicationControllerOperationsImpl(context, superContext);
   }
 
-  @Override
-  public ReplicationController withReplicas(int count) {
-    return accept(r -> r.getSpec().setReplicas(count));
-  }
-
   @Override
   public RollingUpdater<ReplicationController, ReplicationControllerList> getRollingUpdater(long rollingTimeout,
       TimeUnit rollingTimeUnit) {

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/DeploymentOperationsImpl.java

@@ -102,11 +102,6 @@ public RollingUpdater<Deployment, DeploymentList> getRollingUpdater(long rolling
     return null;
   }
 
-  @Override
-  public Deployment withReplicas(int count) {
-    return accept(d -> d.getSpec().setReplicas(count));
-  }
-
   @Override
   public int getCurrentReplicas(Deployment current) {
     return current.getStatus().getReplicas();

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/extensions/v1beta1/ReplicaSetOperationsImpl.java

@@ -71,11 +71,6 @@ public ReplicaSetOperationsImpl newInstance(PodOperationContext context,
     return new ReplicaSetOperationsImpl(context, superContext);
   }
 
-  @Override
-  public ReplicaSet withReplicas(int count) {
-    return accept(r -> r.getSpec().setReplicas(count));
-  }
-
   @Override
   public RollingUpdater<ReplicaSet, ReplicaSetList> getRollingUpdater(long rollingTimeout, TimeUnit rollingTimeUnit) {
     return new ReplicaSetRollingUpdater(context.getClient(), getNamespace(), rollingTimeUnit.toMillis(rollingTimeout),