Skip to content

Commit ec48180

Browse files
rohanKanojiamanusa
authored andcommitted
chore (kubernetes-examples) : Update Kubernetes Examples samples to use up to date code (#4873)
+ Replace deprecated method calls with updated method calls + Replace load(..).get() with load(..).item() calls Signed-off-by: Rohan Kumar <[email protected]>
1 parent 05ff90c commit ec48180

File tree

53 files changed

+208
-150
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+208
-150
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
* Fix #4863: default HttpClient retry logic to 100ms interval
3636
* Fix #4863: default HttpClient retry logic to 10 attempts
3737
* Fix #4865: (java-generator) performance improvements
38+
* Fix #4873: Update all samples in `kubernetes-examples/` module to use up to date code
3839

3940
#### Dependency Upgrade
4041
* Fix #4655: Upgrade Fabric8 Kubernetes Model to Kubernetes v1.26.0

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/BindingExample.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public static void main(String[] args) {
4444
.orElseThrow(() -> new IllegalStateException("No namespace available")).getMetadata().getName();
4545
}
4646

47-
client.pods().inNamespace(namespace).create(new PodBuilder()
47+
client.pods().inNamespace(namespace).resource(new PodBuilder()
4848
.withMetadata(new ObjectMetaBuilder()
4949
.withName(podName)
5050
.build())
@@ -55,16 +55,16 @@ public static void main(String[] args) {
5555
.withImage("nginx:latest")
5656
.endContainer()
5757
.build())
58-
.build());
58+
.build()).create();
5959
final Node firstNode = client.nodes().list().getItems().stream().findFirst()
6060
.orElseThrow(() -> new IllegalStateException("No nodes available"));
61-
client.bindings().inNamespace(namespace).create(new BindingBuilder()
61+
client.bindings().inNamespace(namespace).resource(new BindingBuilder()
6262
.withNewMetadata().withName(podName).endMetadata()
6363
.withNewTarget()
6464
.withKind(firstNode.getKind())
6565
.withApiVersion(firstNode.getApiVersion())
6666
.withName(firstNode.getMetadata().getName()).endTarget()
67-
.build());
67+
.build()).create();
6868
System.out.printf("Successfully bound Pod %s to Node %s%n",
6969
podName, firstNode.getMetadata().getName());
7070
}

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/CRDExample.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import io.fabric8.kubernetes.client.KubernetesClient;
2525
import io.fabric8.kubernetes.client.KubernetesClientBuilder;
2626
import io.fabric8.kubernetes.client.KubernetesClientException;
27+
import io.fabric8.kubernetes.client.Watch;
2728
import io.fabric8.kubernetes.client.Watcher;
2829
import io.fabric8.kubernetes.client.WatcherException;
2930
import io.fabric8.kubernetes.client.dsl.MixedOperation;
@@ -128,7 +129,7 @@ public static void main(String[] args) {
128129
.endSpec()
129130
.build();
130131

131-
client.apiextensions().v1().customResourceDefinitions().create(dummyCRD);
132+
client.apiextensions().v1().customResourceDefinitions().resource(dummyCRD).create();
132133
System.out.println("Created CRD " + dummyCRD.getMetadata().getName());
133134
}
134135

@@ -157,16 +158,16 @@ public static void main(String[] args) {
157158
dummySpec.setFoo("cheese: " + now);
158159
dummy.setSpec(dummySpec);
159160

160-
Dummy created = dummyClient.createOrReplace(dummy);
161+
Dummy created = dummyClient.resource(dummy).createOrReplace();
161162

162163
System.out.println("Upserted " + dummy);
163164

164165
created.getSpec().setBar("otherBar");
165166

166-
dummyClient.createOrReplace(created);
167+
dummyClient.resource(created).createOrReplace();
167168

168169
System.out.println("Watching for changes to Dummies");
169-
dummyClient.withResourceVersion(created.getMetadata().getResourceVersion()).watch(new Watcher<Dummy>() {
170+
Watch watch = dummyClient.withResourceVersion(created.getMetadata().getResourceVersion()).watch(new Watcher<Dummy>() {
170171
@Override
171172
public void eventReceived(Action action, Dummy resource) {
172173
System.out.println("==> " + action + " for " + resource);
@@ -182,6 +183,7 @@ public void onClose(WatcherException cause) {
182183

183184
System.in.read();
184185

186+
watch.close();
185187
} catch (KubernetesClientException e) {
186188
logger.error(e.getMessage(), e);
187189
} catch (Exception e) {

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/CRDLoadExample.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
*/
1616
package io.fabric8.kubernetes.examples;
1717

18-
import io.fabric8.kubernetes.api.model.apiextensions.v1beta1.CustomResourceDefinition;
19-
import io.fabric8.kubernetes.api.model.apiextensions.v1beta1.CustomResourceDefinitionList;
18+
import io.fabric8.kubernetes.api.model.apiextensions.v1.CustomResourceDefinition;
19+
import io.fabric8.kubernetes.api.model.apiextensions.v1.CustomResourceDefinitionList;
2020
import io.fabric8.kubernetes.client.KubernetesClient;
2121
import io.fabric8.kubernetes.client.KubernetesClientBuilder;
2222
import org.slf4j.Logger;
@@ -30,17 +30,17 @@ public static void main(String[] args) {
3030
try (final KubernetesClient client = new KubernetesClientBuilder().build()) {
3131
// List all Custom resources.
3232
logger.info("Listing all current Custom Resource Definitions :");
33-
CustomResourceDefinitionList crdList = client.apiextensions().v1beta1().customResourceDefinitions().list();
33+
CustomResourceDefinitionList crdList = client.apiextensions().v1().customResourceDefinitions().list();
3434
crdList.getItems().forEach(crd -> logger.info(crd.getMetadata().getName()));
3535

3636
// Creating a custom resource from yaml
37-
CustomResourceDefinition aCustomResourceDefinition = client.apiextensions().v1beta1().customResourceDefinitions()
38-
.load(CRDLoadExample.class.getResourceAsStream("/crd.yml")).get();
37+
CustomResourceDefinition aCustomResourceDefinition = client.apiextensions().v1().customResourceDefinitions()
38+
.load(CRDLoadExample.class.getResourceAsStream("/crd.yml")).item();
3939
logger.info("Creating CRD...");
40-
client.apiextensions().v1beta1().customResourceDefinitions().create(aCustomResourceDefinition);
40+
client.apiextensions().v1().customResourceDefinitions().resource(aCustomResourceDefinition).create();
4141

4242
logger.info("Updated Custom Resource Definitions: ");
43-
client.apiextensions().v1beta1().customResourceDefinitions().list().getItems()
43+
client.apiextensions().v1().customResourceDefinitions().list().getItems()
4444
.forEach(crd -> logger.info(crd.getMetadata().getName()));
4545

4646
}

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/ConfigMapExample.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,12 @@ public static void main(String[] args) {
4949
}
5050

5151
String name = "cheese";
52-
Resource<ConfigMap> configMapResource = client.configMaps().inNamespace(namespace).withName(name);
52+
Resource<ConfigMap> configMapResource = client.configMaps().inNamespace(namespace)
53+
.resource(new ConfigMapBuilder().withNewMetadata().withName(name)
54+
.endMetadata().addToData("foo", "" + new Date()).addToData("bar", "beer")
55+
.build());
5356

54-
ConfigMap configMap = configMapResource.createOrReplace(new ConfigMapBuilder().withNewMetadata().withName(name)
55-
.endMetadata().addToData("foo", "" + new Date()).addToData("bar", "beer").build());
57+
ConfigMap configMap = configMapResource.createOrReplace();
5658

5759
logger.info("Upserted ConfigMap at {} data {}", configMap.getMetadata().getSelfLink(), configMap.getData());
5860

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/CreatePod.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public static void main(String[] args) {
6262
namespace = client.getNamespace();
6363
}
6464

65-
List<HasMetadata> resources = client.load(new FileInputStream(fileName)).get();
65+
List<HasMetadata> resources = client.load(new FileInputStream(fileName)).items();
6666
if (resources.isEmpty()) {
6767
logger.error("No resources loaded from file: {}", fileName);
6868
return;
@@ -72,7 +72,7 @@ public static void main(String[] args) {
7272
Pod pod = (Pod) resource;
7373
logger.info("Creating pod in namespace {}", namespace);
7474
NonNamespaceOperation<Pod, PodList, PodResource> pods = client.pods().inNamespace(namespace);
75-
Pod result = pods.create(pod);
75+
Pod result = pods.resource(pod).create();
7676
logger.info("Created pod {}", result.getMetadata().getName());
7777
} else {
7878
logger.error("Loaded resource is not a Pod! {}", resource);

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/CronJobExample.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,12 @@ public static void main(String[] args) {
7070
.build();
7171

7272
log("Creating cron job from object");
73-
cronJob1 = client.batch().v1().cronjobs().inNamespace(namespace).create(cronJob1);
73+
cronJob1 = client.batch().v1().cronjobs().inNamespace(namespace).resource(cronJob1).create();
7474
log("Successfully created cronjob with name ", cronJob1.getMetadata().getName());
7575

7676
log("Watching over pod which would be created during cronjob execution...");
7777
final CountDownLatch watchLatch = new CountDownLatch(1);
78-
try (Watch watch = client.pods().inNamespace(namespace).withLabel("job-name").watch(new Watcher<Pod>() {
78+
try (Watch ignored = client.pods().inNamespace(namespace).withLabel("job-name").watch(new Watcher<Pod>() {
7979
@Override
8080
public void eventReceived(Action action, Pod aPod) {
8181
log(aPod.getMetadata().getName(), aPod.getStatus().getPhase());
@@ -91,8 +91,11 @@ public void onClose(WatcherException e) {
9191
}
9292
})) {
9393
watchLatch.await(2, TimeUnit.MINUTES);
94-
} catch (KubernetesClientException | InterruptedException e) {
95-
log("Could not watch pod", e);
94+
} catch (InterruptedException interruptedException) {
95+
Thread.currentThread().interrupt();
96+
log("Could not watch pod", interruptedException);
97+
} catch (KubernetesClientException kubernetesClientException) {
98+
log("Could not watch pod", kubernetesClientException);
9699
}
97100
} catch (KubernetesClientException exception) {
98101
log("An error occured while processing cronjobs:", exception.getMessage());

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/CustomResourceInformerExample.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,10 @@ public void onDelete(Dummy pod, boolean deletedFinalStateUnknown) {
8989
.map(HasMetadata::getMetadata).map(ObjectMeta::getNamespace).orElse("default"));
9090
}
9191

92-
client.resources(Dummy.class).createOrReplace(toCreate);
92+
client.resources(Dummy.class).resource(toCreate).createOrReplace();
9393
// Wait for some time now
9494
TimeUnit.MINUTES.sleep(5);
95+
podInformer.close();
9596
} catch (InterruptedException interruptedException) {
9697
Thread.currentThread().interrupt();
9798
logger.warn("interrupted: {}", interruptedException.getMessage());

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/CustomResourceV1Example.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ public static void main(String... args) {
5151
.endOpenAPIV3Schema().endSchema()
5252
.endVersion().endSpec().build();
5353
// @formatter:on
54-
kc.apiextensions().v1().customResourceDefinitions().createOrReplace(crd);
54+
kc.apiextensions().v1().customResourceDefinitions().resource(crd).createOrReplace();
5555
System.out.println("Created custom shows.example.com Kubernetes API");
5656
final NonNamespaceOperation<Show, ShowList, Resource<Show>> shows = kc.resources(Show.class, ShowList.class)
5757
.inNamespace("default");
5858
shows.list();
59-
shows.createOrReplace(new Show("breaking-bad", new ShowSpec("Breaking Bad", 10)));
60-
shows.createOrReplace(new Show("better-call-saul", new ShowSpec("Better call Saul", 8)));
61-
shows.createOrReplace(new Show("the-wire", new ShowSpec("The Wire", 10)));
59+
shows.resource(new Show("breaking-bad", new ShowSpec("Breaking Bad", 10))).createOrReplace();
60+
shows.resource(new Show("better-call-saul", new ShowSpec("Better call Saul", 8))).createOrReplace();
61+
shows.resource(new Show("the-wire", new ShowSpec("The Wire", 10))).createOrReplace();
6262
System.out.println("Added three shows");
6363
shows.list().getItems()
6464
.forEach(s -> System.out.printf(" - %s%n", s.getSpec().name));

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/DeleteExamples.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,9 @@ public class DeleteExamples {
3131
public static void main(String[] args) {
3232
try (KubernetesClient client = new KubernetesClientBuilder().build()) {
3333
try {
34-
logger.info("Create namespace: {}", client.namespaces().create(
35-
new NamespaceBuilder().withNewMetadata().withName(NAMESPACE).endMetadata().build()));
34+
logger.info("Create namespace: {}", client.namespaces()
35+
.resource(new NamespaceBuilder().withNewMetadata().withName(NAMESPACE).endMetadata().build())
36+
.create());
3637
logger.info("Deleted namespace: {}", client.namespaces().withName(NAMESPACE).delete());
3738
logger.info("Deleted testPod: {}", client.pods().inNamespace(NAMESPACE).withName("test-pod").delete());
3839
logger.info("Deleted pod by label: {}", client.pods().withLabel("this", "works").delete());

0 commit comments

Comments
 (0)