Skip to content

Commit 6f00632

Browse files
Varun Purifacebook-github-bot
authored andcommitted
Add logging to file for lite interpreter
Summary: Implement file logging for lite interpreter Notes on a few changes: * `log_screen` - a race condition between `self.util.run` would cause the logs to be overwritten despite being read earlier. We don't necessarily need the results of this for xcode, so we simply overwrite this with the logfile contents Weird condition with local testing: * stdout logs don't show up if the benchmark is run while the phone is unlocked. See https://www.internalfb.com/intern/aibench/details/389282756977192 for example. * Logs only show up if the phone is locked at the start of the benchmark, then is manually unlocked after the app is installed https://www.internalfb.com/intern/aibench/details/769472202389124 * Problem does not reproduce on prod devices, for example on iPad: https://www.internalfb.com/intern/aibench/details/945345102000109 Reviewed By: Jack-Khuu Differential Revision: D62042318 fbshipit-source-id: 9acd32860be1633ade8b1cac11cf91d2ae10da5f
1 parent 699a39c commit 6f00632

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

benchmarking/platforms/ios/ios_platform.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ def runBenchmark(self, cmd, *args, **kwargs):
215215
getLogger().info("\n\t[ ======= Benchmark Logs ======= ]")
216216
getLogger().info(logfile_contents)
217217
getLogger().info("\t[ ===== End Benchmark Logs ===== ]\n")
218-
log_screen += logfile_contents
218+
log_screen = logfile_contents
219219
logfile_reader.close()
220220

221221
return log_screen, meta

0 commit comments

Comments
 (0)