Release fix (#2482)

* Fixed CircleCI script for buck release

* Make sure Python3 exists while creating windows release

* Changed logic when reading user emails from GitHub

* Refactored code

Author: Jinlin Zhang

.circleci/config.yml

@@ -1196,6 +1196,17 @@ jobs:
     executor: win/default
     steps:
       - checkout
+      - run:
+          name: Make sure Python3 exists
+          command: |
+            $pythonpath=(Split-Path((Get-Command python).Path))
+            If (Test-Path -Path ${pythonpath}\python3.exe) {
+              echo "using ${pythonpath}\python3.exe"
+            }
+            else {
+              cmd /c mklink ${pythonpath}\python3.exe ${pythonpath}\python.exe
+            }
+          shell: powershell.exe
       - run:
           name: Upgrade pip
           command: python3 -m pip install --upgrade pip

tools/release/releases.py

@@ -64,15 +64,16 @@ def get_current_user(github_token, prefer_fb_email=True):
     response = requests.get(url, headers=headers)
     response.raise_for_status()
     ret = response.json()
-    if not ret["email"].endswith("@fb.com") and prefer_fb_email:
+    default_email = ret["email"]
+    if default_email is None or (not default_email.endswith("@fb.com") and prefer_fb_email):
         while emails_url:
             response = requests.get(emails_url, headers=headers)
             response.raise_for_status()
             fb_email = next(
                 (
                     email["email"]
                     for email in response.json()
-                    if email["verified"] and email["email"].endswith("@fb.com")
+                    if email["verified"] and email["email"].endswith("@fb.com") and (email["visibility"] is None or email["visibility"].lower() == "public")
                 ),
                 None,
             )
@@ -81,6 +82,17 @@ def get_current_user(github_token, prefer_fb_email=True):
                 break
             else:
                 emails_url = response.links.get("next", {}).get("url")
+            if default_email is None:
+                default_email = next(
+                    (
+                        email["email"]
+                        for email in response.json()
+                        if email["verified"] and (email["visibility"] is None or email["visibility"].lower() == "public")
+                    ),
+                    None,
+               )
+    if ret["email"] is None and not default_email is None:
+        ret["email"] = default_email
     return ret