artifacts: Rename uses_content_based_paths to path_resolution_may_require_artifact_value

Summary:
In D92854486 there was some confusion caused by this naming, so lets update it to clarify what this actually means

I've not changed the naming around things like promise artifacts and build artifacts where the name kind of means something different because it's tied to a specific user-facing API

Differential Revision: D92929054

fbshipit-source-id: a6dc018469c85f45ca3c49d17e9aaf223f873948

Author: JakobDegen

app/buck2_action_impl/src/actions/impls/copy.rs

@@ -164,7 +164,7 @@ impl Action for CopyAction {
         let artifact_fs = ctx.fs();
         let src = input.resolve_path(
             artifact_fs,
-            if input.has_content_based_path() {
+            if input.path_resolution_requires_artifact_value() {
                 Some(src_value.content_based_path_hash())
             } else {
                 None

app/buck2_action_impl/src/actions/impls/run.rs

@@ -1444,7 +1444,7 @@ impl Action for RunAction {
         for x in self.starlark_values.outputs_for_error_handler.iter() {
             let artifact = x.inner().artifact();
 
-            let content_based_path_hash = if artifact.has_content_based_path() {
+            let content_based_path_hash = if artifact.path_resolution_requires_artifact_value() {
                 let outputs = outputs.ok_or_else(|| {
                     buck2_error::buck2_error!(
                         buck2_error::ErrorTag::Input,

app/buck2_action_impl/src/actions/impls/run/dep_files.rs

@@ -1358,7 +1358,10 @@ impl DeclaredDepFiles {
 
         for declared_dep_file in self.tagged.values() {
             let dep_file = &declared_dep_file.output;
-            let content_hash = if declared_dep_file.output.has_content_based_path() {
+            let content_hash = if declared_dep_file
+                .output
+                .path_resolution_requires_artifact_value()
+            {
                 Some(
                     result
                         .get_from_artifact_path(&declared_dep_file.output.get_path())
@@ -1415,7 +1418,10 @@ impl DeclaredDepFiles {
         let mut contents = HashMap::with_capacity(self.tagged.len());
 
         for declared_dep_file in self.tagged.values() {
-            let content_hash = if declared_dep_file.output.has_content_based_path() {
+            let content_hash = if declared_dep_file
+                .output
+                .path_resolution_requires_artifact_value()
+            {
                 Some(
                     result
                         .get_from_artifact_path(&declared_dep_file.output.get_path())

app/buck2_action_impl/src/actions/impls/symlinked_dir.rs

@@ -243,7 +243,7 @@ impl Action for SymlinkedDirAction {
 
             let src = src_artifact.resolve_path(
                 ctx.fs(),
-                if src_artifact.has_content_based_path() {
+                if src_artifact.path_resolution_requires_artifact_value() {
                     Some(value.content_based_path_hash())
                 } else {
                     None

app/buck2_action_impl/src/actions/impls/write.rs

@@ -73,7 +73,7 @@ impl CommandLineContentBasedInputVisitor {
 
 impl<'v> CommandLineArtifactVisitor<'v> for CommandLineContentBasedInputVisitor {
     fn visit_input(&mut self, input: ArtifactGroup, _tags: Vec<&ArtifactTag>) {
-        if input.uses_content_based_path() {
+        if input.path_resolution_may_require_artifact_value() {
             self.content_based_inputs.insert(input);
         }
     }
@@ -213,7 +213,7 @@ impl Action for WriteAction {
         let mut content_based_inputs = visitor.content_based_inputs;
         if let Some(macro_files) = &self.inner.macro_files {
             for artifact in macro_files {
-                if artifact.has_content_based_path() {
+                if artifact.path_resolution_requires_artifact_value() {
                     content_based_inputs.insert(ArtifactGroup::Artifact(artifact.dupe()));
                 }
             }

app/buck2_action_impl/src/dynamic/deferred.rs

@@ -466,7 +466,7 @@ async fn materialize_inputs(
     for (artifact, artifact_value) in ensured_artifacts {
         let path = artifact.resolve_path(
             &artifact_fs,
-            if artifact.has_content_based_path() {
+            if artifact.path_resolution_requires_artifact_value() {
                 Some(artifact_value.content_based_path_hash())
             } else {
                 None
@@ -542,7 +542,7 @@ fn artifact_values<'v>(
         let k = StarlarkArtifact::new(artifact.dupe());
         let path = artifact.get_path().resolve(
             artifact_fs,
-            if artifact.has_content_based_path() {
+            if artifact.path_resolution_requires_artifact_value() {
                 Some(artifact_value.content_based_path_hash())
             } else {
                 None
@@ -608,7 +608,7 @@ fn new_attr_value<'v>(
         DynamicAttrValue::ArtifactValue(artifact) => {
             let path = artifact.get_path().resolve(
                 artifact_fs,
-                if artifact.has_content_based_path() {
+                if artifact.path_resolution_requires_artifact_value() {
                     Some(
                         ensured_artifacts
                             .get(artifact)

app/buck2_anon_target/src/anon_target_attr_resolve.rs

@@ -133,7 +133,8 @@ impl AnonTargetAttrResolution for AnonTargetAttr {
                     .unwrap();
 
                 let promise_has_content_based_path = promise_artifact_attr.has_content_based_path;
-                let artifact_has_content_based_path = artifact.has_content_based_path();
+                let artifact_has_content_based_path =
+                    artifact.path_resolution_requires_artifact_value();
                 if artifact_has_content_based_path && !promise_has_content_based_path {
                     return Err(PromiseArtifactResolveError::UsesContentBasedPath(
                         promise_id.clone(),

app/buck2_artifact/src/artifact/artifact_type.rs

@@ -206,7 +206,7 @@ impl Artifact {
         )
     }
 
-    pub fn has_content_based_path(&self) -> bool {
+    pub fn path_resolution_requires_artifact_value(&self) -> bool {
         match self.as_parts().0 {
             BaseArtifactKind::Source(_) => false,
             BaseArtifactKind::Build(b) => b.get_path().is_content_based_path(),
@@ -250,7 +250,7 @@ impl ArtifactDyn for Artifact {
     }
 
     fn has_content_based_path(&self) -> bool {
-        self.has_content_based_path()
+        self.path_resolution_requires_artifact_value()
     }
 
     fn is_projected(&self) -> bool {

app/buck2_build_api/src/actions/execute/action_executor.rs

@@ -407,7 +407,7 @@ impl ActionExecutionCtx for BuckActionExecutionContext<'_> {
         self.inputs
             .iter()
             .filter(|(ag, _)| {
-                if !ag.uses_content_based_path() {
+                if !ag.path_resolution_may_require_artifact_value() {
                     return false;
                 }
 

app/buck2_build_api/src/artifact_groups.rs

@@ -49,22 +49,22 @@ impl PromiseArtifactWrapper {
 }
 
 #[derive(Clone, Debug, Display, Dupe, PartialEq, Eq, Hash, Allocative)]
-#[display("{} {}", key, has_content_based_path)]
+#[display("{} {}", key, path_resolution_may_require_artifact_value)]
 pub struct TransitiveSetProjectionWrapper {
     pub key: TransitiveSetProjectionKey,
-    pub has_content_based_path: bool,
+    pub path_resolution_may_require_artifact_value: bool,
     pub is_eligible_for_dedupe: bool,
 }
 
 impl TransitiveSetProjectionWrapper {
     pub fn new(
         key: TransitiveSetProjectionKey,
-        has_content_based_path: bool,
+        path_resolution_may_require_artifact_value: bool,
         is_eligible_for_dedupe: bool,
     ) -> Self {
         Self {
             key,
-            has_content_based_path,
+            path_resolution_may_require_artifact_value,
             is_eligible_for_dedupe,
         }
     }
@@ -117,10 +117,12 @@ impl ArtifactGroup {
         })
     }
 
-    pub fn uses_content_based_path(&self) -> bool {
+    pub fn path_resolution_may_require_artifact_value(&self) -> bool {
         match self {
-            ArtifactGroup::Artifact(a) => a.has_content_based_path(),
-            ArtifactGroup::TransitiveSetProjection(a) => a.has_content_based_path,
+            ArtifactGroup::Artifact(a) => a.path_resolution_requires_artifact_value(),
+            ArtifactGroup::TransitiveSetProjection(a) => {
+                a.path_resolution_may_require_artifact_value
+            }
             ArtifactGroup::Promise(p) => p.has_content_based_path,
         }
     }