Rename doctest_link_style to doc_link_style

Summary: All the other doctest specific attrs don't start with `doctest` either (`doc_deps`, etc.)

Reviewed By: IanChilds, shayne-fletcher

Differential Revision: D49004162

fbshipit-source-id: 329d692da2d0ae1933db9298a5bcd1431d44c14e

Author: JakobDegen

prelude/decls/rust_rules.bzl

@@ -243,7 +243,7 @@ rust_library = prelude_rule(
             "doc_linker_flags": attrs.list(attrs.arg(), default = []),
             "doc_named_deps": attrs.dict(key = attrs.string(), value = rust_target_dep(is_binary = True), sorted = False, default = {}),
             "doctests": attrs.option(attrs.bool(), default = None),
-            "doctest_link_style": attrs.option(attrs.enum(LinkableDepType), default = None, doc = """
+            "doc_link_style": attrs.option(attrs.enum(LinkableDepType), default = None, doc = """
             Like `link_style` on binaries, but applies specifically to doctests.
             """),
             "proc_macro": attrs.bool(default = False),

prelude/rust/rust_library.bzl

@@ -218,12 +218,12 @@ def rust_library_impl(ctx: AnalysisContext) -> list[Provider]:
     # cares about linkage. So if there is a required link style set for the
     # doctests, reuse those same dependency artifacts for the other build
     # outputs where static vs static_pic does not make a difference.
-    if ctx.attrs.doctest_link_style:
+    if ctx.attrs.doc_link_style:
         static_link_style = {
             "shared": DEFAULT_STATIC_LINK_STYLE,
             "static": LinkStyle("static"),
             "static_pic": LinkStyle("static_pic"),
-        }[ctx.attrs.doctest_link_style]
+        }[ctx.attrs.doc_link_style]
     else:
         static_link_style = DEFAULT_STATIC_LINK_STYLE
 
@@ -243,18 +243,18 @@ def rust_library_impl(ctx: AnalysisContext) -> list[Provider]:
 
     rustdoc_test = None
     if doctests_enabled and toolchain_info.rustc_target_triple == targets.exec_triple(ctx):
-        if ctx.attrs.doctest_link_style:
-            doctest_link_style = LinkStyle(ctx.attrs.doctest_link_style)
+        if ctx.attrs.doc_link_style:
+            doc_link_style = LinkStyle(ctx.attrs.doc_link_style)
         else:
-            doctest_link_style = {
+            doc_link_style = {
                 "any": LinkStyle("shared"),
                 "shared": LinkStyle("shared"),
                 "static": DEFAULT_STATIC_LINK_STYLE,
             }[ctx.attrs.preferred_linkage]
         rustdoc_test_params = build_params(
             rule = RuleType("binary"),
             proc_macro = ctx.attrs.proc_macro,
-            link_style = doctest_link_style,
+            link_style = doc_link_style,
             preferred_linkage = Linkage(ctx.attrs.preferred_linkage),
             lang = LinkageLang("rust"),
             linker_type = compile_ctx.cxx_toolchain_info.linker_info.type,