Allow transformation spec rule to be configured for both cxx binary and test

Summary: With transformation specs being ready for rollout moving arg definition into better place and setting it up for both `cpp_binary` and `cpp_unittest`.

Reviewed By: yahayaohinoyi

Differential Revision: D83559456

fbshipit-source-id: 1010c201108d6ba61357aa9a2a920c9d373ff7a6

Author: Nikita Patskov

prelude/decls/cxx_rules.bzl

@@ -143,6 +143,7 @@ cxx_binary = prelude_rule(
         native_common.link_style() |
         native_common.link_group_deps() |
         native_common.link_group_public_deps_label() |
+        native_common.transformation_spec_arg() |
         buck.deps_query_arg() |
         cxx_common.raw_headers_arg() |
         cxx_common.include_directories_arg() |
@@ -969,6 +970,7 @@ cxx_test = prelude_rule(
         buck.test_rule_timeout_ms() |
         native_common.link_group_deps() |
         native_common.link_group_public_deps_label() |
+        native_common.transformation_spec_arg() |
         native_common.link_style() |
         {
             "additional_coverage_targets": attrs.list(attrs.source(), default = []),

prelude/decls/native_common.bzl

@@ -11,6 +11,7 @@
 # the generated docs, and so those should be verified to be accurate and
 # well-formatted (and then delete this TODO)
 
+load("@prelude//cxx:transformation_spec.bzl", "TransformationResultProvider")
 load(":common.bzl", "LinkableDepType")
 
 def _link_style():
@@ -58,11 +59,21 @@ def _soname():
 """),
     }
 
+def _transformation_spec_arg():
+    return {
+        "transformation_spec": attrs.option(
+            attrs.dep(providers = [TransformationResultProvider]),
+            default = None,
+            doc = "Dependency to a transformation spec that will selectively change parts of dependency graph",
+        ),
+    }
+
 native_common = struct(
     link_group_deps = _link_group_deps,
     link_group_public_deps_label = _link_group_public_deps_label,
     link_style = _link_style,
     link_whole = _link_whole,
     preferred_linkage = _preferred_linkage,
     soname = _soname,
+    transformation_spec_arg = _transformation_spec_arg,
 )

prelude/rules_impl.bzl

@@ -31,7 +31,7 @@ load("@prelude//cxx:cxx_toolchain_types.bzl", "CxxPlatformInfo", "CxxToolchainIn
 load("@prelude//cxx:headers.bzl", "CPrecompiledHeaderInfo", "HeaderMode")
 load("@prelude//cxx:link_groups_types.bzl", "LINK_GROUP_MAP_ATTR")
 load("@prelude//cxx:prebuilt_cxx_library_group.bzl", "prebuilt_cxx_library_group_impl")
-load("@prelude//cxx:transformation_spec.bzl", "TransformationKind", "TransformationResultProvider", "transformation_spec_impl")
+load("@prelude//cxx:transformation_spec.bzl", "TransformationKind", "transformation_spec_impl")
 load("@prelude//cxx:windows_resource.bzl", "windows_resource_impl")
 load("@prelude//decls:android_rules.bzl", "android_rules")
 load("@prelude//decls:common.bzl", "IncludeType", "buck")
@@ -325,17 +325,7 @@ cxx_extra_attributes = {
     },
     "cxx_library": _cxx_extra_library_attrs,
     "cxx_precompiled_header": _cxx_extra_library_attrs,
-    "cxx_test": _merge_dictionaries(
-        [
-            re_test_common.test_args(),
-            {
-                "transformation_spec": attrs.option(
-                    attrs.dep(providers = [TransformationResultProvider]),
-                    default = None,
-                ),
-            },
-        ],
-    ),
+    "cxx_test": re_test_common.test_args(),
     "cxx_toolchain": cxx_toolchain_extra_attributes(is_toolchain_rule = False),
     "llvm_link_bitcode": {
         "_cxx_toolchain": toolchains_common.cxx(),