Commit f248165
Make all swift anon targets content based hashed
Summary:
TSIA
For the anon targets, we could not use `get_uses_experimental_content_based_path_hashing(ctx)` to determine whether we enable content based paths to them (as demonstrated in D86439116)
The reason is that the current setup of rolling out the feature is on a per app basis by adding a modifier to the app's target platform. The issue that brings is that any dependency that is built against the execution platform won't get that information, causing them to still have content based paths disabled. Then, when come to anon targets, if target A and target B both depends on anon target X, if A has content based path enabled and B has it disabled, this would cause an inconsistent state for target X, which leads to a duplicate entry in modulemap.json (https://www.internalfb.com/intern/diffing/?paste_number=2028864153), and hence causing build failures.
The solution, as described by the updated rollout plan: https://docs.google.com/document/d/1tS5CUQ8Xdpx6-hbsUx6NoGXd4VpuZu7FeXtXfHVGoRo/edit?tab=t.0, is that we will be a bit more aggressive in our rollout strategy and just enable content based path by default to the targets that are causing issues.
#buildall-fbobjc
Reviewed By: benb
Differential Revision: D86690264
fbshipit-source-id: 3c976288fee84cc24cbbee6b2067badb9a65825a1 parent a305493 commit f248165
File tree
3 files changed
+6
-0
lines changed- prelude/apple/swift
3 files changed
+6
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
218 | 219 | | |
219 | 220 | | |
220 | 221 | | |
| 222 | + | |
221 | 223 | | |
222 | 224 | | |
223 | 225 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
106 | 107 | | |
107 | 108 | | |
108 | 109 | | |
| |||
283 | 284 | | |
284 | 285 | | |
285 | 286 | | |
| 287 | + | |
286 | 288 | | |
287 | 289 | | |
288 | 290 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
160 | 161 | | |
161 | 162 | | |
162 | 163 | | |
| 164 | + | |
163 | 165 | | |
164 | 166 | | |
165 | 167 | | |
0 commit comments