From b1021d1d8a13763704a60c3ba93bb58816b76fdb Mon Sep 17 00:00:00 2001 From: sebastien Date: Mon, 18 Nov 2024 17:04:00 +0100 Subject: [PATCH 1/3] e2e tests should run test site typechecking --- .github/workflows/tests-e2e.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests-e2e.yml b/.github/workflows/tests-e2e.yml index 632ec27d91e7..e288be9eb568 100644 --- a/.github/workflows/tests-e2e.yml +++ b/.github/workflows/tests-e2e.yml @@ -160,12 +160,15 @@ jobs: - name: Installation run: yarn || yarn || yarn - name: Generate test-website project against main branch - run: yarn test:build:website -s + run: yarn test:build:website -st - name: Install test-website project with npm run: npm install working-directory: ../test-website env: npm_config_registry: http://localhost:4873 + - name: TypeCheck website + working-directory: ../test-website + run: yarn typecheck - name: Start test-website project run: npm run start -- --no-open working-directory: ../test-website @@ -197,12 +200,11 @@ jobs: - name: Installation run: yarn || yarn || yarn - name: Generate test-website project against main branch - run: yarn test:build:website -s + run: yarn test:build:website -st - name: Install test-website project with pnpm run: | npm install -g pnpm - # Fix some peer dependencies errors - pnpm add @algolia/client-search @types/react@17 typescript + pnpm install working-directory: ../test-website env: npm_config_registry: http://localhost:4873 From d0719f5ad8da34426870639b10dad52d6920e5e3 Mon Sep 17 00:00:00 2001 From: sebastien Date: Mon, 18 Nov 2024 17:15:03 +0100 Subject: [PATCH 2/3] e2e tests should run test site typechecking --- .github/workflows/tests-e2e.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/tests-e2e.yml b/.github/workflows/tests-e2e.yml index e288be9eb568..16d3e5b4d5f4 100644 --- a/.github/workflows/tests-e2e.yml +++ b/.github/workflows/tests-e2e.yml @@ -208,6 +208,9 @@ jobs: working-directory: ../test-website env: npm_config_registry: http://localhost:4873 + - name: TypeCheck website + working-directory: ../test-website + run: yarn typecheck - name: Start test-website project run: pnpm start --no-open working-directory: ../test-website From a94b22b529b385ec1f5dc7813537ed121b8a56c3 Mon Sep 17 00:00:00 2001 From: sebastien Date: Mon, 18 Nov 2024 17:36:41 +0100 Subject: [PATCH 3/3] Try to remove base tsconfig types --- packages/docusaurus-tsconfig/tsconfig.json | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/docusaurus-tsconfig/tsconfig.json b/packages/docusaurus-tsconfig/tsconfig.json index d7dca8ef2a9c..b89e41d756c2 100644 --- a/packages/docusaurus-tsconfig/tsconfig.json +++ b/packages/docusaurus-tsconfig/tsconfig.json @@ -11,11 +11,6 @@ "moduleResolution": "bundler", "module": "esnext", "noEmit": true, - "types": [ - "node", - "@docusaurus/module-type-aliases", - "@docusaurus/theme-classic" - ], "baseUrl": ".", "paths": { "@site/*": ["./*"]