fix violations of and enable clang warning: extra-semi-stmt

Reviewed By: Gownta

Differential Revision: D65389971

fbshipit-source-id: 1819925f73f30b432a775c7163a374f3a832994f

Author: yfeldblum

fatal/container/test/flag_set_test.cpp

@@ -59,7 +59,8 @@ void check(TExpectedValue &&expected, TActual &&actual) {
   fx x01##suffix(x01s); fx x23##suffix(x23s); fx x45##suffix(x45s); \
   fx x012345##suffix(x012345s); \
   fx x543210##suffix(x543210s); \
-  fx x051423##suffix(x051423s);
+  fx x051423##suffix(x051423s); \
+  static_assert(true)
 
 //////////
 // ctor //

fatal/container/test/variant_test.cpp

@@ -1586,7 +1586,7 @@ void check_type_tag_size() {
 template <int> struct X {};
 FATAL_TEST(variant, type_tag_size) {
 #define TAG_SIZE_TEST(Expected,...) \
-  check_type_tag_size<Expected, __VA_ARGS__>();
+  check_type_tag_size<Expected, __VA_ARGS__>()
 
   TAG_SIZE_TEST(bool, X<1>);
   TAG_SIZE_TEST(uint8_t, X<1>, X<2>);

fatal/type/test/constify_from_test.cpp

@@ -15,7 +15,7 @@ namespace fatal {
 
 FATAL_TEST(traits, constify_from) {
 # define TEST_IMPL(From, T, ...) \
-  FATAL_EXPECT_SAME<__VA_ARGS__, constify_from<T, From>::type>();
+  FATAL_EXPECT_SAME<__VA_ARGS__, constify_from<T, From>::type>()
 
   TEST_IMPL(int, int &&, int &&);
   TEST_IMPL(int, int &, int &);

fatal/type/test/constify_test.cpp

@@ -15,7 +15,7 @@ namespace fatal {
 
 FATAL_TEST(traits, constify) {
 # define TEST_IMPL(T, ...) \
-  FATAL_EXPECT_SAME<__VA_ARGS__, constify<T>::type>();
+  FATAL_EXPECT_SAME<__VA_ARGS__, constify<T>::type>()
 
   TEST_IMPL(int &&, int const &&);
   TEST_IMPL(int &, int const &);

fatal/type/test/qualifier_test.cpp

@@ -45,7 +45,7 @@ FATAL_TEST(qualifier, cv_qualifier_bitwise_and) {
 
 FATAL_TEST(qualifier, add_const_from) {
 # define TEST_IMPL(From, T, ...) \
-  FATAL_EXPECT_SAME<__VA_ARGS__, add_const_from_t<T, From>>();
+  FATAL_EXPECT_SAME<__VA_ARGS__, add_const_from_t<T, From>>()
 
   TEST_IMPL(int, int &&, int &&);
   TEST_IMPL(int, int &, int &);
@@ -90,7 +90,7 @@ FATAL_TEST(qualifier, add_const_from) {
 
 FATAL_TEST(qualifier, add_volatile_from) {
 # define TEST_IMPL(From, T, ...) \
-  FATAL_EXPECT_SAME<__VA_ARGS__, add_volatile_from_t<T, From>>();
+  FATAL_EXPECT_SAME<__VA_ARGS__, add_volatile_from_t<T, From>>()
 
   TEST_IMPL(int, int &&, int &&);
   TEST_IMPL(int, int &, int &);
@@ -135,7 +135,7 @@ FATAL_TEST(qualifier, add_volatile_from) {
 
 FATAL_TEST(qualifier, add_cv_from) {
 # define TEST_IMPL(From, T, ...) \
-  FATAL_EXPECT_SAME<__VA_ARGS__, add_cv_from_t<T, From>>();
+  FATAL_EXPECT_SAME<__VA_ARGS__, add_cv_from_t<T, From>>()
 
   TEST_IMPL(int, int, int);
   TEST_IMPL(int, int const, int const);
@@ -159,7 +159,7 @@ FATAL_TEST(qualifier, add_cv_from) {
 
 FATAL_TEST(qualifier, add_reference_from) {
 # define TEST_IMPL(From, T, ...) \
-  FATAL_EXPECT_SAME<__VA_ARGS__, add_reference_from_t<T, From>>();
+  FATAL_EXPECT_SAME<__VA_ARGS__, add_reference_from_t<T, From>>()
 
   TEST_IMPL(int &&, int &&, int &&);
   TEST_IMPL(int &&, int &, int &);
@@ -223,7 +223,7 @@ FATAL_TEST(qualifier, add_reference_from) {
 
 FATAL_TEST(qualifier, add_cv_reference_from) {
 # define TEST_IMPL(From, T, ...) \
-  FATAL_EXPECT_SAME<__VA_ARGS__, add_cv_reference_from_t<T, From>>();
+  FATAL_EXPECT_SAME<__VA_ARGS__, add_cv_reference_from_t<T, From>>()
 
   TEST_IMPL(int, int, int);
   TEST_IMPL(int, int const &, int const &);

fatal/type/test/same_reference_as_test.cpp

@@ -15,7 +15,7 @@ namespace fatal {
 
 FATAL_TEST(traits, same_reference_as) {
 # define TEST_IMPL(From, T, ...) \
-  FATAL_EXPECT_SAME<__VA_ARGS__, same_reference_as<T, From>::type>();
+  FATAL_EXPECT_SAME<__VA_ARGS__, same_reference_as<T, From>::type>()
 
   TEST_IMPL(int &&, int &&, int &&);
   TEST_IMPL(int &&, int &, int &&);