Commit bc56055
Fix mac getdeps build for glog > 0.7
Summary: glog 0.7+ requires the preprocessor define `GLOG_USE_GLOG_EXPORT` before including its headers. On GitHub Actions (macOS-latest), `--allow-system-packages` causes getdeps to use Homebrew's glog, which has been updated to 0.7+, breaking the fizz and mvfst builds. Add `add_compile_definitions(GLOG_USE_GLOG_EXPORT)` to fizz and mvfst CMakeLists.txt, and set `INTERFACE_COMPILE_DEFINITIONS` on the `glog::glog` target in FindGlog.cmake for any consumer using the target directly. The define is harmless on older glog versions.
Reviewed By: joanna-jo
Differential Revision: D92770668
fbshipit-source-id: 57ecc2b33eef149453f116cdd05a8b03639306531 parent c88c2db commit bc56055
1 file changed
+2
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
| |||
0 commit comments