Skip to content

Commit 5ff28b2

Browse files
Protick Bhowmickmeta-codesync[bot]
authored andcommitted
Set FEC to NONE for XPHY in platform mapping
Summary: Agera3 will act as a retimer and does not perform FEC encoding/decoding - the IPHY (internal PHY) is responsible for FEC generation. However, the current platform mapping was incorrectly setting FEC to RS544_2N (11) for both xphyLine and xphySystem sides. This diff hardcodes FEC to NONE (1) for XPHY in the platform mapping generation code. **Note**: The current platform mapping CSV structure does not support different FEC values for NPU vs XPHY within the same profile. A follow-up task is filed [here](https://docs.google.com/spreadsheets/d/1TwxOU014IjbmQZLkWiF_TNy9MG8L1-wrqooPAyQSQ64/edit?gid=0#gid=0) to properly account for different FEC types in the CSV. For now, this is hardcoded in the code as a workaround. Reviewed By: harshitgulati18 Differential Revision: D89752851 fbshipit-source-id: e17995156ec2fa8beb8545bcf51120793c2cc075
1 parent f517a14 commit 5ff28b2

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

fboss/agent/platforms/common/ladakh800bcls/Ladakh800bclsPlatformMapping.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70224,14 +70224,14 @@ constexpr auto kJsonPlatformMappingStr = R"(
7022470224
"xphyLine": {
7022570225
"numLanes": 1,
7022670226
"modulation": 2,
70227-
"fec": 11,
70227+
"fec": 1,
7022870228
"medium": 3,
7022970229
"interfaceType": 0
7023070230
},
7023170231
"xphySystem": {
7023270232
"numLanes": 1,
7023370233
"modulation": 2,
70234-
"fec": 11,
70234+
"fec": 1,
7023570235
"medium": 3,
7023670236
"interfaceType": 0
7023770237
}

fboss/lib/platform_mapping_v2/generated_platform_mappings/ladakh800bcls_platform_mapping_is_multi_npu.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70210,14 +70210,14 @@
7021070210
"xphyLine": {
7021170211
"numLanes": 1,
7021270212
"modulation": 2,
70213-
"fec": 11,
70213+
"fec": 1,
7021470214
"medium": 3,
7021570215
"interfaceType": 0
7021670216
},
7021770217
"xphySystem": {
7021870218
"numLanes": 1,
7021970219
"modulation": 2,
70220-
"fec": 11,
70220+
"fec": 1,
7022170221
"medium": 3,
7022270222
"interfaceType": 0
7022370223
}

fboss/lib/platform_mapping_v2/helpers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,8 @@ def get_platform_config_entry(
277277
):
278278
xphy_profile_side_config.numLanes = xphy_speed_setting.num_lanes
279279
xphy_profile_side_config.modulation = xphy_speed_setting.modulation
280-
xphy_profile_side_config.fec = xphy_speed_setting.fec
280+
# Set FEC to NONE for XPHY (retimer PHYs like Agera3 don't do FEC encoding/decoding)
281+
xphy_profile_side_config.fec = FecMode.NONE
281282
if is_xphy(xphy_speed_setting.a_chip_settings.chip_type):
282283
xphy_profile_side_config.interfaceType = (
283284
xphy_speed_setting.a_chip_settings.chip_interface_type

0 commit comments

Comments
 (0)