Commit 2a58d40
Don't define properties and proprety setters for fields in Thrift Unions.
Summary:
Thrift Unions do not provide field-level attributes, and rather require using the explicit getter and setter methods, unlike structures.
This can generate confusion in the users as perfectly valid types lead to runtime failures.
Reviewed By: joshkehn
Differential Revision: D52565429
fbshipit-source-id: 7a33047527ec36f33ca24a879e22902acdd038c51 parent 2bda5b8 commit 2a58d40
File tree
5 files changed
+2
-76
lines changed- thrift/compiler
- generate/templates/pyi
- test/fixtures
- adapter/gen-py/module
- constants/gen-py/module
- pyi/gen-py/simple
- example_asyncio
- example
5 files changed
+2
-76
lines changedLines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| 63 | + | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
| |||
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
| 73 | + | |
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
| |||
Lines changed: 0 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments