Skip to content

Commit 6635a40

Browse files
echistyakovfacebook-github-bot
authored andcommitted
Undo D79220681
Summary: It was reimplemented using ServerObserver in D83169371. Reviewed By: podtserkovskiy Differential Revision: D83169767 fbshipit-source-id: 8f3ef95de0262dbcc64c2951d9a173b0ef219529
1 parent a6fbf34 commit 6635a40

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

thrift/lib/go/thrift/rocket_server_transport.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ func (r *rocketServerTransport) acceptLoop(ctx context.Context) error {
115115
tlsConn, isTLS := conn.(tlsConnectionStaterHandshaker)
116116
if isTLS {
117117
r.observer.ConnTLSAccepted()
118-
r.stats.ConnsTLS.RecordEvent()
119118

120119
err = tlsConn.HandshakeContext(ctx)
121120
if err != nil {

thrift/lib/go/thrift/stats/stats.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ type ServerStats struct {
2828

2929
// counters
3030
ConnsEstablished *TimingSeries // # of new connections
31-
ConnsTLS *TimingSeries // # of new TLS connections
3231
ConnsClosed *TimingSeries // # of server closed connections
3332
ClientClosed *TimingSeries // # of client closed connections
3433
ConnectionPreemptedWork *TimingSeries // event where we didn't perform work due to connection being closed
@@ -113,7 +112,6 @@ func NewServerStats(cfg *TimingConfig, statsPeriod time.Duration) *ServerStats {
113112

114113
// events/duration stats
115114
ConnsEstablished: NewTimingSeries(cfg),
116-
ConnsTLS: NewTimingSeries(cfg),
117115
ConnsClosed: NewTimingSeries(cfg),
118116
ClientClosed: NewTimingSeries(cfg),
119117
ConnectionPreemptedWork: NewTimingSeries(cfg),
@@ -159,8 +157,6 @@ func (stats *ServerStats) GetInts() map[string]int64 {
159157

160158
s := stats.ConnsEstablished.MustSummarize(stats.statsPeriod)
161159
ints["connections.established."+periodStr] = int64(s.Count)
162-
s = stats.ConnsTLS.MustSummarize(stats.statsPeriod)
163-
ints["connections.tls."+periodStr] = int64(s.Count)
164160
s = stats.ConnsClosed.MustSummarize(stats.statsPeriod)
165161
ints["connections.closed."+periodStr] = int64(s.Count)
166162
s = stats.ClientClosed.MustSummarize(stats.statsPeriod)

thrift/lib/go/thrift/stats/stats_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ func TestStats(t *testing.T) {
3030
ints := stats.GetInts()
3131
expectedInts := map[string]int64{
3232
"connections.client_ended.60": 0,
33-
"connections.tls.60": 0,
3433
"connections.closed.60": 0,
3534
"connections.connected": 0,
3635
"connections.connection_preempted_work.60": 0,

0 commit comments

Comments
 (0)