You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
Currently, `iobuf` depends on `minibytes` just to do:
unsafe impl BytesToIOufSharedExt for minibytes::Bytes
It makes the OSS world's `Cargo.toml` story tricky. I don't think `minibytes`
should be moved to `folly/rust` (`folly/rust` should be just pure bindings to
folly C++).
Switching (making `minibytes` depend on `iobuf`) is annoying too, partially
because there is no `Cargo.toml` for `iobuf` right now. So let's make it
possible to construct `IOBufShared` without explicitly
`unsafe impl BytesToIOufSharedExt`.
Reviewed By: muirdm
Differential Revision: D79678311
fbshipit-source-id: f79ea3c5312908ee26887f49c88cb2d91fe28b58
0 commit comments