Skip to content

Commit d967b59

Browse files
ahornbyfacebook-github-bot
authored andcommitted
fix cmake xxhash discovery
Summary: Fix fb303 OSS builds on macOS that failing to find xxhash.h. Problem was that thrift cpp lib now needs xxhash but it wasn't declared in the cmake rules, which shows up as a problem when system xxhash is not installed. CustomCompressorRegistry.cpp was also missing from cmake build resulting in link errors once the xxhash.h discovery was fixed. Reviewed By: markbt Differential Revision: D72452460 fbshipit-source-id: 6bdb8e0e3961529f04f9d9d29ba0daeff2e7ff2a
1 parent ef5160f commit d967b59

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

build/fbcode_builder/CMake/FBThriftCppLibrary.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ function(add_fbthrift_cpp_library LIB_NAME THRIFT_FILE)
144144
PUBLIC
145145
"$<BUILD_INTERFACE:${CMAKE_BINARY_DIR}>"
146146
"$<INSTALL_INTERFACE:${ARG_INCLUDE_DIR}>"
147+
${Xxhash_INCLUDE_DIR}
147148
)
148149
target_link_libraries(
149150
"${LIB_NAME}"
@@ -153,6 +154,7 @@ function(add_fbthrift_cpp_library LIB_NAME THRIFT_FILE)
153154
Folly::folly
154155
mvfst::mvfst_server_async_tran
155156
mvfst::mvfst_server
157+
${Xxhash_LIBRARY}
156158
)
157159

158160
# Add ${generated_headers} to the PUBLIC_HEADER property for ${LIB_NAME}

0 commit comments

Comments
 (0)