Unregister URIs from Reverse MBP Fallback

Reviewed By: malmeida

Differential Revision: D66250348

fbshipit-source-id: 9acbac48acb7169989c58a6e977d2b07fcaf1aa5

Author: Veeren Mandalia

urimod/src/main/java/com/facebook/fresco/urimod/NopUriModifier.kt

@@ -24,4 +24,6 @@ object NopUriModifier : UriModifierInterface {
   ): ModificationResult = ModificationResult.Disabled("NopUriModifier")
 
   override fun modifyPrefetchUri(uri: Uri, callerContext: Any?): Uri = uri
+
+  override fun unregisterReverseFallbackUri(uri: Uri) = Unit
 }

urimod/src/main/java/com/facebook/fresco/urimod/UriModifierInterface.kt

@@ -25,6 +25,8 @@ interface UriModifierInterface {
 
   fun modifyPrefetchUri(uri: Uri, callerContext: Any?): Uri?
 
+  fun unregisterReverseFallbackUri(uri: Uri)
+
   sealed class ModificationResult(private val comment: String) {
 
     abstract val bestAllowlistedSize: Int?

vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt

@@ -169,6 +169,12 @@ class VitoImagePipelineImpl(
     imagePipeline.evictFromCache(uri)
   }
 
+  override fun hintUnmodifiedUri(imageRequest: VitoImageRequest) {
+    imageRequest.finalImageRequest?.sourceUri?.let {
+      UriModifier.INSTANCE.unregisterReverseFallbackUri(it)
+    }
+  }
+
   private fun experimentalDynamicSizeVito2(): Boolean = config.experimentalDynamicSizeVito2()
 
   private fun experimentalDynamicSizeWithCacheFallbackVito2(): Boolean =

vito/core/src/main/java/com/facebook/fresco/vito/core/VitoImagePipeline.kt

@@ -65,4 +65,6 @@ interface VitoImagePipeline {
   fun evictFromCaches(imageRequest: VitoImageRequest) {
     throw UnsupportedOperationException("Method not implemented: evictFromCaches")
   }
+
+  fun hintUnmodifiedUri(imageRequest: VitoImageRequest) = Unit
 }

vito/litho/src/main/java/com/facebook/fresco/vito/litho/FrescoVitoImage2Spec.kt

@@ -196,6 +196,9 @@ object FrescoVitoImage2Spec {
         forceKeepOriginalSize.set(isInDiskCache != false)
       }
       if (forceKeepOriginalSize.get() == true) {
+        // Tell image pipeline that we're using an unmodified URL so it can ensure we can prefetch
+        FrescoVitoProvider.getImagePipeline().hintUnmodifiedUri(requestCachedValue)
+
         // Prefetch in OnPrepare since no prefetch will happen in OnBoundsDefined
         maybePrefetchInOnPrepare(
             prefetch,