Commit ce4d35e
Fix missing native dependencies on packaged artifacts (#2748)
Summary:
## Motivation (required)
Latest versions of Fresco have missing .so files due to a race condition on Gradle tasks.
I'm imposing a task dependencies on `ndk_build_*` steps and `preBuild` steps to prevent this.
Fixes #2722
Fixes #2747
## Test Plan (required)
I've tested this against `./gradlew publishToMavenLocal` upon clean build.
Here the output:
```
$ unzip -l ~/.m2/repository/com/facebook/fresco/nativeimagetranscoder/3.1.1/nativeimagetranscoder-3.1.1.aar
Archive: /Users/ncor/.m2/repository/com/facebook/fresco/nativeimagetranscoder/3.1.1/nativeimagetranscoder-3.1.1.aar
Length Date Time Name
--------- ---------- ----- ----
7297 02-01-1980 00:00 R.txt
216 02-01-1980 00:00 AndroidManifest.xml
6034 02-01-1980 00:00 classes.jar
121 02-01-1980 00:00 META-INF/com/android/build/gradle/aar-metadata.properties
0 02-01-1980 00:00 jni/
0 02-01-1980 00:00 jni/arm64-v8a/
475392 02-01-1980 00:00 jni/arm64-v8a/libnative-imagetranscoder.so
0 02-01-1980 00:00 jni/armeabi-v7a/
271736 02-01-1980 00:00 jni/armeabi-v7a/libnative-imagetranscoder.so
0 02-01-1980 00:00 jni/x86/
557648 02-01-1980 00:00 jni/x86/libnative-imagetranscoder.so
0 02-01-1980 00:00 jni/x86_64/
621000 02-01-1980 00:00 jni/x86_64/libnative-imagetranscoder.so
--------- -------
1939444 13 files
```
Pull Request resolved: #2748
Reviewed By: passy
Differential Revision: D50641344
Pulled By: cortinico
fbshipit-source-id: c518b4cf4e418dcec1ac30a78c03a649d5c66c131 parent c266579 commit ce4d35e
File tree
5 files changed
+20
-1
lines changed- animated-gif
- imagepipeline-native
- native-filters
- native-imagetranscoder
- static-webp
5 files changed
+20
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| 63 | + | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
74 | 79 | | |
75 | 80 | | |
76 | 81 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
78 | 82 | | |
79 | 83 | | |
80 | 84 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
| |||
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
79 | 82 | | |
80 | 83 | | |
81 | 84 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
60 | 66 | | |
61 | 67 | | |
62 | 68 | | |
0 commit comments