Skip to content

Commit 20dcccb

Browse files
Diana Marsalafacebook-github-bot
authored andcommitted
codemod to backfill MICI memoize callsites
Summary: As a part of the DEIC project ([wiki](https://www.internalfb.com/wiki/Hack_Foundation/DEIC_and_Memoization_options/)), we need to apply memoization categorizations to all memoized functions in www. Up until this point we have been adding these labels to only functions that access the implicit context. However, now, we will require categorizations to be added to every memoize function, regardless of whether they access the implicit context or not. These diffs adds explicit `#MakeICInaccessible` annotations to memoized functions in www that currently do not specify a categorization. **This `#MakeICInaccessible` is equivalent to the existing behaviour and therefore this diff is a no-op**. This diff applies explicit categories to files found in the following paste P1839309173, and was generated using the `AddDefaultMemoizeAnnotation` script Differential Revision: D76640349 fbshipit-source-id: 3bc9fb4e8017dd2e6dc6eda7b1d2f0521778a82f
1 parent acbd3f1 commit 20dcccb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

third-party/thrift/src/thrift/lib/hack/src/ThriftServiceMethodNameVirtualPolicyEnforcer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ final class ThriftServiceMethodNameVirtualPolicyEnforcer
1010
const PolicyEnforcerAssetClass ASSET_CLASS =
1111
PolicyEnforcerAssetClass::THRIFT_CLIENT;
1212

13-
<<__Memoize>>
13+
<<__Memoize(#MakeICInaccessible)>>
1414
private static function getPrivacyLibObject(
1515
ThriftServiceMethodNameAssetXID $asset_xid,
1616
string $sr_config_service_name,

0 commit comments

Comments
 (0)