Fix CQS signal. Id] 98468593 -- performance-faster-string-find in fbcode/hphp/runtime/ext/vsdebug

Reviewed By: dtolnay

Differential Revision: D74639660

fbshipit-source-id: ba48f7b6b9168ba2f4eb93808c455f988d6a9ac4

Author: generatedunixname89002005287564

hphp/runtime/ext/vsdebug/command.cpp

@@ -145,7 +145,7 @@ std::string VSCommand::trimString(const std::string str) {
 }
 
 std::string VSCommand::removeVariableNamePrefix(const std::string& str) {
-  if (str.find("$") == 0) {
+  if (str.find('$') == 0) {
     return str.substr(1);
   } else if (str.find("::$") == 0) {
     return str.substr(3);

hphp/runtime/ext/vsdebug/completions_command.cpp

@@ -267,8 +267,8 @@ void CompletionsCommand::addMemberCompletions(
   // Don't execute the evaluation if the input string looks like it might
   // contain a function call. This could have side effects we don't want to
   // cause during auto complete suggestions and it's better to be safe here.
-  if (context.matchContext.find("(") != std::string::npos ||
-      context.matchContext.find(")") != std::string::npos ||
+  if (context.matchContext.find('(') != std::string::npos ||
+      context.matchContext.find(')') != std::string::npos ||
       trimString(context.matchContext).size() == 0) {
 
     return;