Add removeCookie method

Summary: As titled a new utility method to remove a certain cookie from the request.

Reviewed By: afrind

Differential Revision: D76707379

fbshipit-source-id: e7bf2257fb4ac513a3988aecc831761cbf369c21

Author: Shravan Gajjela

third-party/proxygen/src/proxygen/lib/http/HTTPMessage.cpp

@@ -454,6 +454,41 @@ const StringPiece HTTPMessage::getCookie(const string& name) const {
   }
 }
 
+void HTTPMessage::removeCookie(const string& name) {
+  unparseCookies();
+  if (!parsedCookies_) {
+    parseCookies();
+  }
+
+  auto it = cookies_.find(name);
+  if (it == cookies_.end()) {
+    return;
+  }
+
+  // Remove cookie
+  cookies_.erase(it);
+
+  // Reconstruct the Cookie header from remaining cookies
+  if (cookies_.empty()) {
+    // No cookies remaining
+    headers_.remove(HTTP_HEADER_COOKIE);
+  } else {
+    // Build new cookie header value
+    std::vector<std::string> cookieStrings;
+    cookieStrings.reserve(cookies_.size());
+    for (const auto& cookie : cookies_) {
+      cookieStrings.emplace_back(cookie.first.str() + "=" +
+                                 cookie.second.str());
+    }
+
+    // Set the new Cookie header
+    headers_.set(HTTP_HEADER_COOKIE, folly::join("; ", cookieStrings));
+  }
+
+  // Clear parsed cookies
+  unparseCookies();
+}
+
 void HTTPMessage::parseQueryParams() const {
   DCHECK(!parsedQueryParams_);
   const Request& req = request();

third-party/proxygen/src/proxygen/lib/http/HTTPMessage.h

@@ -632,6 +632,11 @@ class HTTPMessage {
    */
   const folly::StringPiece getCookie(const std::string& name) const;
 
+  /**
+   * Remove the cookie with the specified name.
+   */
+  void removeCookie(const std::string& name);
+
   /**
    * Print the message out.
    */

third-party/proxygen/src/proxygen/lib/http/test/HTTPMessageTest.cpp

@@ -55,6 +55,68 @@ TEST(HTTPMessage, TestParseCookiesMultipleCookies) {
   EXPECT_EQ(msg.getCookie("Name"), "");
 }
 
+TEST(HTTPMessage, TestRemoveCookie) {
+  HTTPMessage msg;
+
+  // Test removing a cookie that exists
+  msg.getHeaders().set("Cookie",
+                       "id=1256679245; data=0:1234567; session=abc123");
+  EXPECT_EQ(msg.getCookie("id"), "1256679245");
+  EXPECT_EQ(msg.getCookie("data"), "0:1234567");
+  EXPECT_EQ(msg.getCookie("session"), "abc123");
+
+  // Remove middle cookie
+  msg.removeCookie("data");
+  EXPECT_EQ(msg.getCookie("id"), "1256679245");
+  EXPECT_EQ(msg.getCookie("data"), "");
+  EXPECT_EQ(msg.getCookie("session"), "abc123");
+
+  // Verify Cookie header was reconstructed properly
+  const std::string& cookieHeader = msg.getHeaders().getSingleOrEmpty("Cookie");
+  EXPECT_TRUE(cookieHeader.find("id=1256679245") != std::string::npos);
+  EXPECT_TRUE(cookieHeader.find("session=abc123") != std::string::npos);
+  EXPECT_TRUE(cookieHeader.find("data=0:1234567") == std::string::npos);
+
+  // Remove first cookie
+  msg.removeCookie("id");
+  EXPECT_EQ(msg.getCookie("id"), "");
+  EXPECT_EQ(msg.getCookie("session"), "abc123");
+
+  // Remove last remaining cookie - should remove Cookie header entirely
+  msg.removeCookie("session");
+  EXPECT_EQ(msg.getCookie("session"), "");
+  EXPECT_FALSE(msg.getHeaders().exists("Cookie"));
+}
+
+TEST(HTTPMessage, TestRemoveCookieNonExistent) {
+  HTTPMessage msg;
+
+  // Test removing a cookie that doesn't exist
+  msg.getHeaders().set("Cookie", "id=1256679245; data=0:1234567");
+
+  // Try to remove non-existent cookie
+  msg.removeCookie("nonexistent");
+
+  // Original cookies should still be there
+  EXPECT_EQ(msg.getCookie("id"), "1256679245");
+  EXPECT_EQ(msg.getCookie("data"), "0:1234567");
+
+  // Cookie header should be unchanged
+  const std::string& cookieHeader = msg.getHeaders().getSingleOrEmpty("Cookie");
+  EXPECT_TRUE(cookieHeader.find("id=1256679245") != std::string::npos);
+  EXPECT_TRUE(cookieHeader.find("data=0:1234567") != std::string::npos);
+}
+
+TEST(HTTPMessage, TestRemoveCookieEmptyHeader) {
+  HTTPMessage msg;
+
+  // Test removing cookie when no Cookie header exists
+  msg.removeCookie("nonexistent");
+
+  EXPECT_FALSE(msg.getHeaders().exists("Cookie"));
+  EXPECT_EQ(msg.getCookie("nonexistent"), "");
+}
+
 TEST(HTTPMessage, TestParseQueryParamsSimple) {
   HTTPMessage msg;
   string url =