Fix redundant-constexpr-static-def in mcrouter/lib/MessageQueue.h +4

Summary:
LLVM has a warning `-Wdeprecated-redundant-constexpr-static-def` which we are enabling to reduce unnecessary code.

For questions/comments, contact r-barnes.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: meyering

Differential Revision: D77194591

fbshipit-source-id: d3f817fa69182cdafb9ebffae6c1580b152650fd

Author: r-barnes

third-party/mcrouter/src/mcrouter/lib/MessageQueue.h

@@ -353,9 +353,5 @@ class MessageQueue {
   std::shared_ptr<folly::EventBase::LoopCallback> queueDrainCallback_;
 };
 
-// Static member definition
-template <class T>
-constexpr int64_t MessageQueue<T>::kWakeupEveryMs;
-
 } // namespace memcache
 } // namespace facebook

third-party/mcrouter/src/mcrouter/lib/carbon/Stats.h

@@ -178,13 +178,4 @@ class Stats {
   RateStats rateStats_;
 };
 
-template <class RouterInfo>
-constexpr std::array<folly::StringPiece, Stats<RouterInfo>::SumStats::kNumStats>
-    Stats<RouterInfo>::SumStats::kStatNames;
-
-template <class RouterInfo>
-constexpr std::
-    array<folly::StringPiece, Stats<RouterInfo>::RateStats::kNumStats>
-        Stats<RouterInfo>::RateStats::kStatNames;
-
 } // namespace carbon

third-party/mcrouter/src/mcrouter/lib/network/TypedMsg-inl.h

@@ -39,11 +39,6 @@ struct CallDispatcherImplExpanded<List<Ms...>, MaxId, Proc, Args...> {
       {DispatchImpl<Ms, Proc, Args...>::func...}};
 };
 
-/* Array needs definition outside of the class */
-template <class... Ms, size_t MaxId, class Proc, class... Args>
-constexpr std::array<DispatchFunc<Proc, Args...>, MaxId + 1>
-    CallDispatcherImplExpanded<List<Ms...>, MaxId, Proc, Args...>::array_;
-
 // Sort List<Ms...> by M::typeId, expand to fill 0s, call ImplExpanded
 template <class... Ms, class Proc, class... Args>
 struct CallDispatcherImpl<List<Ms...>, Proc, Args...>

third-party/mcrouter/src/mcrouter/routes/LoadBalancerRoute.h

@@ -328,11 +328,6 @@ class LoadBalancerRoute {
   }
 };
 
-template <class RouterInfo>
-constexpr folly::StringPiece LoadBalancerRoute<RouterInfo>::kWeightedHashing;
-template <class RouterInfo>
-constexpr folly::StringPiece LoadBalancerRoute<RouterInfo>::kTwoRandomChoices;
-
 template <class RouterInfo>
 struct LoadBalancerRouteOptions {
   folly::StringPiece salt;