Introduce SourceIndexedTypeSystem::toSerializeableTypeSystem

Summary: populate SerializableThriftSourceInfo

Reviewed By: praihan

Differential Revision: D79908882

fbshipit-source-id: 05dba5e84a57567486b6103846b9867803ac1eba

Author: thedavekwon

third-party/thrift/src/thrift/lib/cpp2/dynamic/TypeSystem.cpp

@@ -524,6 +524,26 @@ SerializableTypeSystem TypeSystem::toSerializableTypeSystem(
   return result;
 }
 
+SerializableTypeSystem SourceIndexedTypeSystem::toSerializableTypeSystem(
+    const folly::F14FastSet<Uri>& uris) const {
+  SerializableTypeSystem result;
+  for (const auto& uri : uris) {
+    auto def = getUserDefinedTypeOrThrow(uri);
+
+    SerializableTypeDefinitionEntry entry;
+    entry.definition() = toSerializableDefinition(def);
+    auto sourceInfoView = getSourceIdentiferForUserDefinedType(def);
+    if (sourceInfoView.has_value()) {
+      auto& s = entry.sourceInfo().ensure();
+      s.locator() = sourceInfoView->location;
+      s.name() = sourceInfoView->name;
+    };
+    result.types()->emplace(uri, std::move(entry));
+  }
+
+  return result;
+}
+
 } // namespace apache::thrift::type_system
 
 std::size_t std::hash<apache::thrift::type_system::DefinitionRef>::operator()(

third-party/thrift/src/thrift/lib/cpp2/dynamic/TypeSystem.h

@@ -490,6 +490,12 @@ class SourceIndexedTypeSystem : public TypeSystem {
    */
   virtual NameToDefinitionsMap getUserDefinedTypesAtLocation(
       std::string_view location) const = 0;
+
+  /**
+   * Creates SerializbleTypeSystem from this TypeSystem.
+   */
+  SerializableTypeSystem toSerializableTypeSystem(
+      const folly::F14FastSet<Uri>& uris) const;
 };
 
 /**

third-party/thrift/src/thrift/lib/cpp2/dynamic/test/TypeSystemTest.cpp

@@ -1349,6 +1349,30 @@ TEST(TypeSystemTest, SourceIndexedTypeSystem) {
         &typeSystem->getUserDefinedType("meta.com/thrift/test/OpaqueAlias")
              ->asOpaqueAlias());
   }
+
+  auto sts = sym.toSerializableTypeSystem(*sym.getKnownUris());
+  EXPECT_EQ(sts.types()->size(), 4);
+  auto& structWithI32FieldEntry =
+      sts.types()->at("meta.com/thrift/test/StructWithI32Field");
+  EXPECT_EQ(
+      structWithI32FieldEntry.sourceInfo()->locator(), "file://foo/bar.thrift");
+  EXPECT_EQ(structWithI32FieldEntry.sourceInfo()->name(), "StructWithI32Field");
+
+  auto& enumEntry = sts.types()->at("meta.com/thrift/test/Enum");
+  EXPECT_EQ(enumEntry.sourceInfo()->locator(), "file://foo/bar.thrift");
+  EXPECT_EQ(enumEntry.sourceInfo()->name(), "Enum");
+
+  auto& unionWithI32FieldEntry =
+      sts.types()->at("meta.com/thrift/test/UnionWithI32Field");
+  EXPECT_EQ(
+      unionWithI32FieldEntry.sourceInfo()->locator(),
+      "file://foo/other.thrift");
+  EXPECT_EQ(unionWithI32FieldEntry.sourceInfo()->name(), "UnionWithI32Field");
+
+  auto& opaqueAliasEntry = sts.types()->at("meta.com/thrift/test/OpaqueAlias");
+  EXPECT_EQ(
+      opaqueAliasEntry.sourceInfo()->locator(), "file://foo/other.thrift");
+  EXPECT_EQ(opaqueAliasEntry.sourceInfo()->name(), "OpaqueAlias");
 }
 
 TEST(TypeSystemTest, SourceIndexedTypeSystemWithDuplicateEntries) {