Convert VipStats, PoolStats, and ConnectionStats histograms to QuantileStats for memory optimization

Summary:
This diff converts all histogram metrics in VipStats, PoolStats, and ConnectionStats to QuantileStats to reduce memory usage while maintaining the same percentile estimates.

NOTE: this will change metric values somewhat since QuantileState compute percentiles differently than Histograms. I think this is fine, however, since QuantileStats should be more accurate for head and tail values in the distribution.

Reviewed By: dddmello

Differential Revision: D79019775

fbshipit-source-id: 16c76ca971a19425c4cfa2842a4f3c8f6bb43623

Author: Keivaun Waugh

third-party/proxygen/src/proxygen/lib/http/stats/ConnectionStats.cpp

@@ -29,13 +29,8 @@ MinimalConnectionStats::MinimalConnectionStats(const std::string& prefix,
     ingressBodyBytes_.emplace(prefix + "_ingress_body_bytes", SUM, RATE);
 
     totalDuration_.emplace(prefix + "_conn_duration",
-                           100,
-                           0,
-                           5000,
-                           facebook::fb303::AVG,
-                           50,
-                           95,
-                           99);
+                           facebook::stats::ExportTypeConsts::kAvg,
+                           facebook::fb303::QuantileConsts::kP50_P95_P99);
     currConns_.emplace(prefix + "_conn");
     newConns_.emplace(prefix + "_new_conn", SUM);
     currTcpConns_.emplace(prefix + "_tcp_conn");
@@ -71,7 +66,7 @@ void MinimalConnectionStats::recordResponse(
 }
 
 void MinimalConnectionStats::recordDuration(size_t duration) {
-  BaseStats::addToOptionalStat(totalDuration_, duration);
+  BaseStats::addValueToOptionalStat(totalDuration_, duration);
 }
 
 void MinimalConnectionStats::addEgressBytes(size_t bytes) {

third-party/proxygen/src/proxygen/lib/http/stats/ConnectionStats.h

@@ -12,10 +12,13 @@
 
 #include <proxygen/lib/http/stats/TLResponseCodeStats.h>
 
+#include "common/stats/DynamicStats.h"
 #include <proxygen/lib/stats/StatsWrapper.h>
 
 namespace proxygen {
 
+using QuantileStatWrapper = facebook::fb303::detail::QuantileStatWrapper;
+
 /**
  * Connection stats abstract interface.
  */
@@ -85,7 +88,7 @@ class MinimalConnectionStats : public ConnectionStats {
   std::optional<StatsWrapper::TLTimeseriesMinuteAndAllTime> egressBodyBytes_;
   std::optional<StatsWrapper::TLTimeseriesMinuteAndAllTime> ingressBodyBytes_;
   std::optional<StatsWrapper::TLTimeseriesMinute> upstreamLoadShed_;
-  std::optional<StatsWrapper::TLHistogram> totalDuration_;
+  std::optional<QuantileStatWrapper> totalDuration_;
 
   std::optional<StatsWrapper::TLCounter> currConns_;
   std::optional<StatsWrapper::TLTimeseries> newConns_;