Include file that define assertx

Summary:
- Make sure to include headers for macros
- Have X-inl.h files require to be only included from X.h

Reviewed By: mdko

Differential Revision: D73640689

fbshipit-source-id: a134d1c088645b2c81674a5e9815eac80901d69b

Author: WizKid

hphp/runtime/base/hash-table-inl.h

@@ -14,6 +14,11 @@
    +----------------------------------------------------------------------+
 */
 
+#ifndef incl_HPHP_HASH_TABLE_INL_H_
+#error "hash-table-inl.h should only be included by hash-table.h"
+#endif
+
+#include "hphp/util/assertions.h"
 #include "hphp/util/configs/server.h"
 #include "hphp/util/portability.h"
 

hphp/runtime/base/hash-table.h

@@ -522,4 +522,6 @@ struct HashTable : HashTableCommon {
 }  // namespace array
 }  // namespace HPHP
 
+#define incl_HPHP_HASH_TABLE_INL_H_
 #include "hphp/runtime/base/hash-table-inl.h"
+#undef incl_HPHP_HASH_TABLE_INL_H_

hphp/runtime/base/memory-manager-inl.h

@@ -14,13 +14,17 @@
    +----------------------------------------------------------------------+
 */
 
-#pragma once
+#ifndef incl_HPHP_MEMORY_MANAGER_INL_H_
+#error "memory-manager-inl.h should only be included by memory-manager.h"
+#endif
 
 #include <limits>
 #include <utility>
 
+#include "hphp/util/assertions.h"
 #include "hphp/util/bitops.h"
 #include "hphp/util/compilation-flags.h"
+#include "hphp/util/trace.h"
 
 namespace HPHP {
 

hphp/runtime/base/memory-manager.h

@@ -1136,4 +1136,6 @@ void reset_alloc_sampling();
 
 }
 
+#define incl_HPHP_MEMORY_MANAGER_INL_H_
 #include "hphp/runtime/base/memory-manager-inl.h"
+#undef incl_HPHP_MEMORY_MANAGER_INL_H_

hphp/runtime/ext/asio/asio-context-enter-inl.h

@@ -19,6 +19,8 @@
 #error "This should only be included by asio-context-enter.h"
 #endif
 
+#include <folly/Likely.h>
+
 namespace HPHP::asio {
 ///////////////////////////////////////////////////////////////////////////////
 

hphp/runtime/ext/asio/ext_async-function-wait-handle-inl.h

@@ -19,6 +19,8 @@
 #error "This should only be included by ext_async-function-wait-handle.h"
 #endif
 
+#include "hphp/util/assertions.h"
+
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
 

hphp/runtime/ext/hsl/replace_every_nonrecursive.h

@@ -16,6 +16,7 @@
    +----------------------------------------------------------------------+
 */
 
+#include "hphp/util/assertions.h"
 
 namespace HPHP {
 

hphp/runtime/vm/act-rec-inl.h

@@ -14,8 +14,15 @@
    +----------------------------------------------------------------------+
 */
 
+#ifndef incl_HPHP_VM_ACT_REC_INL_H_
+#error "act-rec-inl.h should only be included by act-rec.h"
+#endif
+
+#include "hphp/util/assertions.h"
 #include "hphp/util/compilation-flags.h"
 
+#include <folly/Likely.h>
+
 namespace HPHP {
 
 ///////////////////////////////////////////////////////////////////////////////

hphp/runtime/vm/act-rec.h

@@ -294,5 +294,6 @@ bool isCallToExit(uint64_t address);
 
 }
 
+#define incl_HPHP_VM_ACT_REC_INL_H_
 #include "hphp/runtime/vm/act-rec-inl.h"
-
+#undef incl_HPHP_VM_ACT_REC_INL_H_

hphp/runtime/vm/func-emitter-inl.h

@@ -18,6 +18,10 @@
 #error "func-emitter-inl.h should only be included by func-emitter.h"
 #endif
 
+#include "hphp/util/assertions.h"
+
+#include <folly/Likely.h>
+
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////