Sort class arrays before returning them

Summary:
D76565975 added a test case where the order of the subtypes from the native facts extension was different in `-m jit` vs `-m interp`. Restore that case, and sort the `Array` before returning it.

Note: I'm only changing the ones that return `class<T>`, have not tested the other Facts functions.

Reviewed By: jano

Differential Revision: D76939342

fbshipit-source-id: 4b6e59c0c591f16b621cb7132d247eae103dc977

Author: vassilmladenov

hphp/runtime/ext/facts/facts-store.cpp

@@ -354,7 +354,9 @@ Array makeVecOfLazyClass(const std::vector<Symbol<SymKind::Type>>& vector) {
   for (auto const& str : vector) {
     ret.append(make_tv<KindOfLazyClass>(LazyClassData::create(str.get())));
   }
-  return ret.toArray();
+  auto arr = ret.toArray();
+  arr.get()->sort(0, true);
+  return arr;
 }
 
 /**

hphp/test/slow/class-ptr/facts/facts.php

@@ -2,7 +2,7 @@
 
 class C { public function __construct() { echo nameof static."\n"; }}
 class D extends C {}
-// class E extends C {} // TODO(T227568155)
+class E extends C {}
 class F extends D {}
 
 function v($a): void {

hphp/test/slow/class-ptr/facts/facts.php.expect

@@ -1,7 +1,9 @@
 ===== subtypes =====
 D
+E
 ===== transitive_subtypes =====
 D
+E
 F
 ===== supertypes =====
 D