fix: std::copy in small_vector can trigger GCC -Warray-bounds (#2223)

mhx · facebook-github-bot · commit d0a752b64169 · 2024-06-17T15:14:26.000-07:00
Summary: Pull Request resolved: facebook/folly#2223 Reviewed By: Gownta Differential Revision: D58197967 Pulled By: Orvid fbshipit-source-id: db99b9817d6c620be35330414195c6025ef2523c
diff --git a/third-party/folly/src/folly/container/small_vector.h b/third-party/folly/src/folly/container/small_vector.h
@@ -1037,7 +1037,10 @@ class small_vector
 
   void copyWholeInlineStorageTrivial(small_vector const& o) {
     static_assert(std::is_trivially_copyable_v<Value>);
+    FOLLY_PUSH_WARNING
+    FOLLY_GCC_DISABLE_WARNING("-Warray-bounds")
     std::copy(o.u.buffer(), o.u.buffer() + MaxInline, u.buffer());
+    FOLLY_POP_WARNING
     this->setSize(o.size());
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1037,7 +1037,10 @@ class small_vector`
`1037`	`1037`
`1038`	`1038`	`void copyWholeInlineStorageTrivial(small_vector const& o) {`
`1039`	`1039`	`static_assert(std::is_trivially_copyable_v<Value>);`
	`1040`	`+ FOLLY_PUSH_WARNING`
	`1041`	`+ FOLLY_GCC_DISABLE_WARNING("-Warray-bounds")`
`1040`	`1042`	`std::copy(o.u.buffer(), o.u.buffer() + MaxInline, u.buffer());`
	`1043`	`+ FOLLY_POP_WARNING`
`1041`	`1044`	`this->setSize(o.size());`
`1042`	`1045`	`}`
`1043`	`1046`