Remove sendPriority() in HTTPSession/HQSession

Summary: Removing HTTP 2 priority API `sendPriority()` in `HTTPSession`/`HQSession`.

Reviewed By: hanidamlaj

Differential Revision: D72091448

fbshipit-source-id: 1b89e2fb98d3115d0ab604fa7b11cb31fb629c5f

Author: Joanna Jo

third-party/proxygen/src/proxygen/httpclient/samples/pricli/CMakeLists.txt

@@ -377,24 +377,6 @@ class HQSession
     return sock_->setKnob(knobSpace, knobId, std::move(knobBlob));
   }
 
-  /**
-   * Sends a priority message on this session.  If the underlying protocol
-   * doesn't support priority, this is a no-op.  A new stream identifier will
-   * be selected and returned.
-   */
-  HTTPCodec::StreamID sendPriority(http2::PriorityUpdate /*pri*/) override {
-    return 0;
-  }
-
-  /**
-   * As above, but updates an existing priority node.  Do not use for
-   * real nodes, prefer HTTPTransaction::changePriority.
-   */
-  size_t sendPriority(HTTPCodec::StreamID /*id*/,
-                      http2::PriorityUpdate /*pri*/) override {
-    return 0;
-  }
-
   size_t sendPriority(HTTPCodec::StreamID id, HTTPPriority pri);
   size_t sendPushPriority(hq::PushId pushId, HTTPPriority pri);
 

third-party/proxygen/src/proxygen/httpclient/samples/pricli/PriCli.cpp

@@ -2698,36 +2698,6 @@ void HTTPSession::PingProber::onPingReply(uint64_t pingVal) {
   refreshTimeout(/*onIngress=*/false);
 }
 
-HTTPCodec::StreamID HTTPSession::sendPriority(http2::PriorityUpdate pri) {
-  if (!codec_->supportsParallelRequests()) {
-    // For HTTP/1.1, don't call createStream()
-    return 0;
-  }
-  auto id = codec_->createStream();
-  sendPriority(id, pri);
-  return id;
-}
-
-size_t HTTPSession::sendPriority(HTTPCodec::StreamID id,
-                                 http2::PriorityUpdate pri) {
-  auto res = sendPriorityImpl(id, pri);
-  txnEgressQueue_.addOrUpdatePriorityNode(id, pri);
-  return res;
-}
-
-size_t HTTPSession::sendPriorityImpl(HTTPCodec::StreamID id,
-                                     http2::PriorityUpdate pri) {
-  CHECK_NE(id, 0);
-  const size_t bytes = codec_->generatePriority(
-      writeBuf_,
-      id,
-      std::make_tuple(pri.streamDependency, pri.exclusive, pri.weight));
-  if (bytes) {
-    scheduleWrite();
-  }
-  return bytes;
-}
-
 HTTPTransaction* HTTPSession::findTransaction(HTTPCodec::StreamID streamID) {
   if (lastTxn_ && streamID == lastTxn_->getID()) {
     return lastTxn_;

third-party/proxygen/src/proxygen/lib/http/session/HQSession.h

@@ -209,20 +209,6 @@ class HTTPSession
    */
   size_t sendPing() override;
 
-  /**
-   * Sends a priority message on this session.  If the underlying protocol
-   * doesn't support priority, this is a no-op.  A new stream identifier will
-   * be selected and returned.
-   */
-  HTTPCodec::StreamID sendPriority(http2::PriorityUpdate pri) override;
-
-  /**
-   * As above, but updates an existing priority node.  Do not use for
-   * real nodes, prefer HTTPTransaction::changePriority.
-   */
-  size_t sendPriority(HTTPCodec::StreamID id,
-                      http2::PriorityUpdate pri) override;
-
   /**
    * Send a CERTIFICATE_REQUEST frame. If the underlying protocol doesn't
    * support secondary authentication, this is a no-op and 0 is returned.
@@ -408,14 +394,6 @@ class HTTPSession
 
   size_t getCodecSendWindowSize() const;
 
-  /**
-   * Sends a priority message on this session.  If the underlying protocol
-   * doesn't support priority, this is a no-op.  Returns the number of bytes
-   * written on the transport
-   */
-  size_t sendPriorityImpl(HTTPCodec::StreamID streamID,
-                          http2::PriorityUpdate pri);
-
   bool onNativeProtocolUpgradeImpl(HTTPCodec::StreamID txn,
                                    std::unique_ptr<HTTPCodec> codec,
                                    const std::string& protocolString);