Use reflect codec for testset.thrift

Summary: Reattempt of D73820947, but this time with a missing fix for unions.

Reviewed By: a-lafrance

Differential Revision: D74633836

fbshipit-source-id: 370ad63ef80a2fce89c16f6f2fcb59d5524db405

Author: echistyakov

third-party/thrift/src/thrift/compiler/generate/templates/go/types/struct_method_write.mustache

@@ -22,7 +22,7 @@
 func (x *{{struct:go_name}}) Write(p thrift.Encoder) error {
     {{#struct:union?}}
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("{{struct:go_name}} write union: no more than one field must be set (%d set).", countSet)
     }
     {{/struct:union?}}
     if err := p.WriteStructBegin("{{struct:name}}"); err != nil {

third-party/thrift/src/thrift/compiler/generate/templates/go/types/struct_method_write_v2.mustache

@@ -20,6 +20,11 @@
 
 }}
 func (x *{{struct:go_name}}) Write(p thrift.Encoder) error {
+    {{#struct:union?}}
+    if countSet := x.countSetFields(); countSet > 1 {
+        return fmt.Errorf("{{struct:go_name}} write union: no more than one field must be set (%d set).", countSet)
+    }
+    {{/struct:union?}}
     return thrift.WriteStructSpec(p, x, x.getStructSpec())
 }
 {{!newline}}

third-party/thrift/src/thrift/compiler/test/fixtures/adapter/out/go/gen-go/module/types.go

@@ -2774,7 +2774,7 @@ func (x *Baz) CountSetFieldsBaz() int {
 
 func (x *Baz) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("Baz write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("Baz"); err != nil {
         return thrift.PrependError("Baz write struct begin error: ", err)
@@ -6888,7 +6888,7 @@ func (x *AdaptTestUnion) CountSetFieldsAdaptTestUnion() int {
 
 func (x *AdaptTestUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("AdaptTestUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("AdaptTestUnion"); err != nil {
         return thrift.PrependError("AdaptTestUnion write struct begin error: ", err)

third-party/thrift/src/thrift/compiler/test/fixtures/basic-annotations/out/go/gen-go/module/types.go

@@ -306,7 +306,7 @@ func (x *MyUnion) CountSetFieldsMyUnion() int {
 
 func (x *MyUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("MyUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("MyUnion"); err != nil {
         return thrift.PrependError("MyUnion write struct begin error: ", err)

third-party/thrift/src/thrift/compiler/test/fixtures/basic/out/go/gen-go/module/types.go

@@ -1391,7 +1391,7 @@ func (x *MyUnion) CountSetFieldsMyUnion() int {
 
 func (x *MyUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("MyUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("MyUnion"); err != nil {
         return thrift.PrependError("MyUnion write struct begin error: ", err)
@@ -2248,7 +2248,7 @@ func (x *UnionToBeRenamed) CountSetFieldsUnionToBeRenamed() int {
 
 func (x *UnionToBeRenamed) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("UnionToBeRenamed write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("UnionToBeRenamed"); err != nil {
         return thrift.PrependError("UnionToBeRenamed write struct begin error: ", err)

third-party/thrift/src/thrift/compiler/test/fixtures/complex-union/out/go/gen-go/module/types.go

@@ -503,7 +503,7 @@ func (x *ComplexUnion) CountSetFieldsComplexUnion() int {
 
 func (x *ComplexUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("ComplexUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("ComplexUnion"); err != nil {
         return thrift.PrependError("ComplexUnion write struct begin error: ", err)
@@ -785,7 +785,7 @@ func (x *ListUnion) CountSetFieldsListUnion() int {
 
 func (x *ListUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("ListUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("ListUnion"); err != nil {
         return thrift.PrependError("ListUnion write struct begin error: ", err)
@@ -990,7 +990,7 @@ func (x *DataUnion) CountSetFieldsDataUnion() int {
 
 func (x *DataUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("DataUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("DataUnion"); err != nil {
         return thrift.PrependError("DataUnion write struct begin error: ", err)
@@ -1419,7 +1419,7 @@ func (x *ValUnion) CountSetFieldsValUnion() int {
 
 func (x *ValUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("ValUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("ValUnion"); err != nil {
         return thrift.PrependError("ValUnion write struct begin error: ", err)
@@ -1625,7 +1625,7 @@ func (x *VirtualComplexUnion) CountSetFieldsVirtualComplexUnion() int {
 
 func (x *VirtualComplexUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("VirtualComplexUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("VirtualComplexUnion"); err != nil {
         return thrift.PrependError("VirtualComplexUnion write struct begin error: ", err)
@@ -1895,7 +1895,7 @@ func (x *NonCopyableUnion) CountSetFieldsNonCopyableUnion() int {
 
 func (x *NonCopyableUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("NonCopyableUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("NonCopyableUnion"); err != nil {
         return thrift.PrependError("NonCopyableUnion write struct begin error: ", err)

third-party/thrift/src/thrift/compiler/test/fixtures/constants/out/go/gen-go/module/types.go

@@ -1882,7 +1882,7 @@ func (x *Union1) CountSetFieldsUnion1() int {
 
 func (x *Union1) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("Union1 write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("union1"); err != nil {
         return thrift.PrependError("Union1 write struct begin error: ", err)
@@ -2202,7 +2202,7 @@ func (x *Union2) CountSetFieldsUnion2() int {
 
 func (x *Union2) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("Union2 write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("union2"); err != nil {
         return thrift.PrependError("Union2 write struct begin error: ", err)

third-party/thrift/src/thrift/compiler/test/fixtures/doctext/out/go/gen-go/module/types.go

@@ -355,7 +355,7 @@ func (x *U) CountSetFieldsU() int {
 
 func (x *U) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("U write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("U"); err != nil {
         return thrift.PrependError("U write struct begin error: ", err)

third-party/thrift/src/thrift/compiler/test/fixtures/empty-struct/out/go/gen-go/module/types.go

@@ -111,7 +111,7 @@ func (x *Nada) CountSetFieldsNada() int {
 
 func (x *Nada) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("Nada write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("Nada"); err != nil {
         return thrift.PrependError("Nada write struct begin error: ", err)

third-party/thrift/src/thrift/compiler/test/fixtures/terse_write/out/go/gen-go/terse_write/types.go

@@ -1060,7 +1060,7 @@ func (x *MyUnion) CountSetFieldsMyUnion() int {
 
 func (x *MyUnion) Write(p thrift.Encoder) error {
     if countSet := x.countSetFields(); countSet > 1 {
-        return fmt.Errorf("%T write union: no more than one field must be set (%d set).", x, countSet)
+        return fmt.Errorf("MyUnion write union: no more than one field must be set (%d set).", countSet)
     }
     if err := p.WriteStructBegin("MyUnion"); err != nil {
         return thrift.PrependError("MyUnion write struct begin error: ", err)